Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: Source/modules/fetch/DataConsumerHandleUtil.cpp

Issue 1198313002: Implement debugName() in WebDataConsumerHandle subclasses in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Style fix. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/fetch/CompositeDataConsumerHandle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/fetch/DataConsumerHandleUtil.cpp
diff --git a/Source/modules/fetch/DataConsumerHandleUtil.cpp b/Source/modules/fetch/DataConsumerHandleUtil.cpp
index 587b92628168468b8e970e4809d1ed2ade7d8d63..e6d9e2491e8e83ddc8d756d1fea8744521947e64 100644
--- a/Source/modules/fetch/DataConsumerHandleUtil.cpp
+++ b/Source/modules/fetch/DataConsumerHandleUtil.cpp
@@ -39,6 +39,8 @@ private:
}
};
Reader* obtainReaderInternal(Client*) override { return new ReaderImpl; }
+
+ const char* debugName() const override { return "WaitingHandle"; }
};
class RepeatingReader final : public WebDataConsumerHandle::Reader {
@@ -69,11 +71,13 @@ private:
class DoneHandle final : public WebDataConsumerHandle {
private:
Reader* obtainReaderInternal(Client* client) override { return new RepeatingReader(Done, client); }
+ const char* debugName() const override { return "DoneHandle"; }
};
class UnexpectedErrorHandle final : public WebDataConsumerHandle {
private:
Reader* obtainReaderInternal(Client* client) override { return new RepeatingReader(UnexpectedError, client); }
+ const char* debugName() const override { return "UnexpectedErrorHandle"; }
};
class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle {
@@ -102,6 +106,8 @@ private:
Reader* obtainReaderInternal(Client* client) override { return new ReaderImpl(m_handle->obtainReader(client)); }
+ const char* debugName() const override { return m_handle->debugName(); }
+
OwnPtr<WebDataConsumerHandle> m_handle;
};
« no previous file with comments | « Source/modules/fetch/CompositeDataConsumerHandle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698