pkg/compiler/lib/src/js_emitter/code_emitter_task.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix new emitter. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/runtime_types.dart ('K') | « pkg/compiler/lib/src/js_emitter/class_stub_generator.dart ('k') | pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart » ('j') | pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

diff --git a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

index 59fe76ae18539aa14655ccfd8bffa0443f91e259..1513dc39575afe31a5f4fb0bac1bd697b57df5a6 100644

--- a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

+++ b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

@@ -4,7 +4,7 @@

part of dart2js.js_emitter;

-const USE_NEW_EMITTER = const bool.fromEnvironment("dart2js.use.new.emitter");

+const USE_NEW_EMITTER = true; //const bool.fromEnvironment("dart2js.use.new.emitter");

floitsch 2015/06/22 17:43:44 debug.

herhut 2015/06/23 13:26:31 Done.

/**

* Generates the code for all used classes in the program. Static fields (even

@@ -216,8 +216,8 @@ class CodeEmitterTask extends CompilerTask {

backend.retainMetadataOf(cls);

oldEmitter.classEmitter.visitFields(cls, false,

(Element member,

- String name,

- String accessorName,

+ jsAst.Name name,

+ jsAst.Name accessorName,

bool needsGetter,

bool needsSetter,

bool needsCheckedSetter) {