tests/compiler/dart2js/mirrors_used_test.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/mirrors_used_test.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('K') | « tests/compiler/dart2js/interceptor_test.dart ('k') | tests/compiler/dart2js/static_closure_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/mirrors_used_test.dart

diff --git a/tests/compiler/dart2js/mirrors_used_test.dart b/tests/compiler/dart2js/mirrors_used_test.dart

index 653135f20ff32b6c5bdfc3a0725cacef0b39fcda..3b2bb39012760b5a876c1ca4154405ddfdd5bb4f 100644

--- a/tests/compiler/dart2js/mirrors_used_test.dart

+++ b/tests/compiler/dart2js/mirrors_used_test.dart

@@ -86,6 +86,7 @@ void main() {

];

JavaScriptBackend backend = compiler.backend;

Iterable<String> nativeNames = nativeClasses.map(backend.namer.className);

+ expectedNames = expectedNames.map(backend.namer.asName).toList();

expectedNames.addAll(nativeNames);

Set recordedNames = new Set()