sdk/lib/_internal/compiler/js_lib/js_mirrors.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('K') | « sdk/lib/_internal/compiler/js_lib/js_helper.dart ('k') | sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

index cb70f011ec8bd1feaaf00fdede501e7020d2858d..5815a32be154d016d57f2d1acd4166c2c930b57a 100644

--- a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

+++ b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

@@ -1984,7 +1984,7 @@ class JsClassMirror extends JsTypeMirror with JsObjectMirror

var type = getType(typeInformation[0]);

_superclass = typeMirrorFromRuntimeTypeRepresentation(this, type);

} else {

- var superclassName = _fieldsDescriptor.split(';')[0];

+ var superclassName = _fieldsDescriptor.split(';')[0].split(':')[0];

// TODO(zarah): Remove special handing of mixins.

var mixins = superclassName.split('+');

if (mixins.length > 1) {