pkg/js_ast/lib/src/template.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/js_ast/lib/src/template.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('K') | « pkg/js_ast/lib/src/printer.dart ('k') | sdk/lib/_internal/compiler/js_lib/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/js_ast/lib/src/template.dart

diff --git a/pkg/js_ast/lib/src/template.dart b/pkg/js_ast/lib/src/template.dart

index c3dca1979305d90083a67b65ca9b2a6f4ab40b6a..632f273bfd1c74e668f0a896ec437c5f101d9cea 100644

--- a/pkg/js_ast/lib/src/template.dart

+++ b/pkg/js_ast/lib/src/template.dart

@@ -685,6 +685,8 @@ class InstantiatorGeneratorVisitor implements NodeVisitor<Instantiator> {

};

}

+ Instantiator visitName(Name node) => same(node);

Instantiator visitArrayInitializer(ArrayInitializer node) {

// TODO(sra): Implement splicing?

List<Instantiator> elementMakers = node.elements

« pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('K') | « pkg/js_ast/lib/src/printer.dart ('k') | sdk/lib/_internal/compiler/js_lib/js_helper.dart » ('j') | no next file with comments »