pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('K') | « pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart

index 9edfdcef53a32b1e47915b4569970f9cbc962424..833abebe06bea27e4a7ea1f6bb0aab2f8a31eedd 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart

@@ -10,7 +10,8 @@ const DEBUG_FAST_OBJECTS = false;

/**

* Call-back for adding property with [name] and [value].

-typedef jsAst.Property AddPropertyFunction(String name, jsAst.Expression value);

+typedef jsAst.Property AddPropertyFunction(jsAst.Name name,

+ jsAst.Expression value);

/**

* [member] is a field (instance, static, or top level).

@@ -31,8 +32,8 @@ typedef jsAst.Property AddPropertyFunction(String name, jsAst.Expression value);

* type assertions are enabled (checked mode).

typedef void AcceptField(VariableElement member,

- String name,

- String accessorName,

+ jsAst.Name name,

+ jsAst.Name accessorName,

bool needsGetter,

bool needsSetter,

bool needsCheckedSetter);