dart2js: Use an abstract Name class for names in the generated JavaScript ast.

pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.new_js_emitter.emitter;
 
 import 'package:_internal/compiler/js_lib/shared/embedded_names.dart' show
     JsBuiltin,
     METADATA,
     TYPES;
@@ skipping 58 matching lines @@
     return _emitter.generateEmbeddedGlobalAccess(global);
   }
 
   @override
   // TODO(herhut): Use a single shared function.
   js.Expression generateFunctionThatReturnsNull() {
     return js.js('function() {}');
   }
 
   js.PropertyAccess _globalPropertyAccess(Element element) {
-    String name = namer.globalPropertyName(element);
-    js.PropertyAccess pa = new js.PropertyAccess.field(
-        new js.VariableUse(namer.globalObjectFor(element)),
-        name);
+    js.Name name = namer.globalPropertyName(element);
+    js.PropertyAccess pa = new js.PropertyAccess(
+        new js.VariableUse(namer.globalObjectFor(element)), name);
     return pa;
   }
 
   @override
   js.Expression isolateLazyInitializerAccess(FieldElement element) {
     return js.js('#.#', [namer.globalObjectFor(element),
                          namer.lazyInitializerName(element)]);
   }
 
   @override
@@ skipping 63 matching lines @@
       case JsBuiltin.createFunctionTypeRti:
         return _backend.rti.representationGenerator
             .templateForCreateFunctionType;
 
       case JsBuiltin.isSubtype:
         // TODO(floitsch): move this closer to where is-check properties are
         // built.
         String isPrefix = namer.operatorIsPrefix;
         return js.js.expressionTemplateFor("('$isPrefix' + #) in #.prototype");
 
-      case JsBuiltin.isFunctionTypeRti:
-        String functionClassName =
-            _backend.namer.runtimeTypeName(_compiler.functionClass);
-        return js.js.expressionTemplateFor(
-            '#.$typeNameProperty === "$functionClassName"');
-
-      case JsBuiltin.isNullTypeRti:
-        String nullClassName =
-            _backend.namer.runtimeTypeName(_compiler.nullClass);
-        return js.js.expressionTemplateFor(
-            '#.$typeNameProperty === "$nullClassName"');
-
-      case JsBuiltin.isDartObjectTypeRti:
-        String dartObjectClassName =
-            _backend.namer.runtimeTypeName(_compiler.objectClass);
-        return js.js.expressionTemplateFor(
-            '#.$typeNameProperty === "$dartObjectClassName"');
+      case JsBuiltin.isGivenTypeRti:
+        return js.js.expressionTemplateFor('#.$typeNameProperty === #');
 
       case JsBuiltin.getMetadata:
         return _emitter.templateForReadMetadata;
 
       case JsBuiltin.getType:
         return _emitter.templateForReadType;
 
       default:
         _compiler.internalError(NO_LOCATION_SPANNABLE,
                                 "Unhandled Builtin: $builtin");
         return null;
     }
   }
 
   @override
   void invalidateCaches() {
   }
 }