dart2js: Use an abstract Name class for names in the generated JavaScript ast.

pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.ir_builder_task;
 
 import '../closure.dart' as closurelib;
 import '../closure.dart' hide ClosureScope;
 import '../constants/expressions.dart';
 import '../dart_types.dart';
 import '../dart2jslib.dart';
 import '../elements/elements.dart';
 import '../elements/modelx.dart' show SynthesizedConstructorElementX,
     ConstructorBodyElementX, FunctionSignatureX;
 import '../io/source_information.dart';
-import '../js_backend/js_backend.dart' show JavaScriptBackend;
+import '../js_backend/js_backend.dart' show JavaScriptBackend,
+    SyntheticConstantKind;
 import '../resolution/semantic_visitor.dart';
 import '../resolution/operators.dart' as op;
 import '../tree/tree.dart' as ast;
 import '../universe/universe.dart' show SelectorKind, CallStructure;
 import '../constants/values.dart' show ConstantValue;
 import 'cps_ir_nodes.dart' as ir;
 import 'cps_ir_builder.dart';
 import '../native/native.dart' show NativeBehavior;
 
 // TODO(karlklose): remove.
-import '../js/js.dart' as js show js, Template, Expression;
+import '../js/js.dart' as js show js, Template, Expression, Name;
 import '../ssa/ssa.dart' show TypeMaskFactory;
 import '../types/types.dart' show TypeMask;
 import '../util/util.dart';
 
 import 'package:_internal/compiler/js_lib/shared/embedded_names.dart'
     show JsBuiltin, JsGetName;
 import '../constants/values.dart';
 
 typedef void IrBuilderCallback(Element element, ir.FunctionDefinition irNode);
 
@@ skipping 2976 matching lines @@
 
       case 'JS_BUILTIN':
         // The first argument is a description of the type and effect of the
         // builtin, which has already been analyzed in the frontend.  The second
         // argument must be a [JsBuiltin] value.  All other arguments are
         // values used by the JavaScript template that is associated with the
         // builtin.
         validateArgumentCount(minimum: 2);
 
         ast.Node builtin = argumentNodes.tail.head;
-        JsBuiltin value = getEnumValue(argumentNodes.tail.head,
-            backend.jsBuiltinEnum, JsBuiltin.values);
+        JsBuiltin value = getEnumValue(builtin, backend.jsBuiltinEnum,
+                                       JsBuiltin.values);
         js.Template template = backend.emitter.builtinTemplateFor(value);
         List<ir.Primitive> arguments =
             argumentNodes.skip(2).mapToList(visit, growable: false);
         return irBuilder.buildForeignCode(template, arguments, behavior);
 
       case 'JS_EMBEDDED_GLOBAL':
         validateArgumentCount(exactly: 2);
 
         String name = expectStringConstant(argumentNodes.tail.head);
         js.Expression access =
@@ skipping 18 matching lines @@
 
       case 'JS_EFFECT':
         return irBuilder.buildNullConstant();
 
       case 'JS_GET_NAME':
         validateArgumentCount(exactly: 1);
 
         ast.Node argument = argumentNodes.head;
         JsGetName id = getEnumValue(argument, backend.jsGetNameEnum,
             JsGetName.values);
-        String name = backend.namer.getNameForJsGetName(argument, id);
-        return irBuilder.buildStringConstant(name);
+        js.Name name = backend.namer.getNameForJsGetName(argument, id);
+        ConstantValue nameConstant =
+            new SyntheticConstantValue(SyntheticConstantKind.NAME,
+                                       js.js.quoteName(name));
+
+        return irBuilder.buildConstant(nameConstant);
 
       case 'JS_GET_FLAG':
         validateArgumentCount(exactly: 1);
 
         String name = expectStringConstant(argumentNodes.first);
         bool value = false;
         switch (name) {
           case 'MUST_RETAIN_METADATA':
             value = backend.mustRetainMetadata;
             break;
@@ skipping 110 matching lines @@
   }
 
   processSetStatic(ir.SetStatic node) {
     node.body = replacementFor(node.body);
   }
 
   processContinuation(ir.Continuation node) {
     node.body = replacementFor(node.body);
   }
 }