Issue 1198253002: Remove broken optimization unwrapping number wrappers on setting array.length

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1198253002: Remove broken optimization unwrapping number wrappers on setting array.length (Closed)

Created:
5 years, 6 months ago by Toon Verwaest

Modified:
5 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove broken optimization unwrapping number wrappers on setting array.length Can't imagine it's very useful; lets restore/fix once it becomes relevant BUG= Committed: https://crrev.com/d195c6f9bd61f3693965c09c3db859ef5d57ba03 Cr-Commit-Position: refs/heads/master@{#29181}

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	src/accessors.cc	View		1 chunk	+1 line, -10 lines	0 comments	Download
	M	test/mjsunit/array-length.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198253002/1

5 years, 6 months ago (2015-06-22 10:27:32 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-22 10:49:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d195c6f9bd61f3693965c09c3db859ef5d57ba03
Cr-Commit-Position: refs/heads/master@{#29181}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages