Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 119823002: drive: Show files shared to me from other account's shared folder. (Closed)

Created:
7 years ago by kinaba
Modified:
7 years ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

drive: Show files shared to me from other account's shared folder. See the associated BUG for the detailed reproducing steps. This CL is to stop handling such shared files as errors and starts storing them in local metadata. BUG=326043 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242087

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M chrome/browser/chromeos/drive/change_list_processor.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor.cc View 1 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/test/data/gdata/delta_file_added_in_new_but_deleted_directory.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
7 years ago (2013-12-20 07:37:41 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/119823002/diff/20001/chrome/browser/chromeos/drive/change_list_processor.cc File chrome/browser/chromeos/drive/change_list_processor.cc (right): https://codereview.chromium.org/119823002/diff/20001/chrome/browser/chromeos/drive/change_list_processor.cc#newcode250 chrome/browser/chromeos/drive/change_list_processor.cc:250: if (error != FILE_ERROR_OK) { nit; Could you ...
7 years ago (2013-12-20 07:41:56 UTC) #2
kinaba
https://codereview.chromium.org/119823002/diff/20001/chrome/browser/chromeos/drive/change_list_processor.cc File chrome/browser/chromeos/drive/change_list_processor.cc (right): https://codereview.chromium.org/119823002/diff/20001/chrome/browser/chromeos/drive/change_list_processor.cc#newcode250 chrome/browser/chromeos/drive/change_list_processor.cc:250: if (error != FILE_ERROR_OK) { On 2013/12/20 07:41:56, hashimoto ...
7 years ago (2013-12-20 07:51:46 UTC) #3
hashimoto
lgtm
7 years ago (2013-12-20 07:53:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/119823002/40001
7 years ago (2013-12-20 07:58:52 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-20 13:06:14 UTC) #6
Message was sent while issue was closed.
Change committed as 242087

Powered by Google App Engine
This is Rietveld 408576698