Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: content/browser/accessibility/browser_accessibility.h

Issue 1198203002: Fix accessibility objects with zero width and height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aria-owns-test
Patch Set: Clarify, don't assume child bounds are nonempty too Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/browser_accessibility.h
diff --git a/content/browser/accessibility/browser_accessibility.h b/content/browser/accessibility/browser_accessibility.h
index 643e5950d5a485afbea2450a8fb6224ada79a7f6..27f6a74c8b2f0919b13b15aae19f6a4ed4cec720 100644
--- a/content/browser/accessibility/browser_accessibility.h
+++ b/content/browser/accessibility/browser_accessibility.h
@@ -283,6 +283,12 @@ class CONTENT_EXPORT BrowserAccessibility {
// bounds offsets.
BrowserAccessibility* GetParentForBoundsCalculation() const;
+ // If a bounding rectangle is empty, compute it based on the union of its
+ // children, since most accessibility APIs don't like elements with no
+ // bounds, but "virtual" elements in the accessibility tree that don't
+ // correspond to a layed-out element sometimes don't have bounds.
+ void FixEmptyBounds(gfx::Rect* bounds) const;
+
// Convert the bounding rectangle of an element (which is relative to
// its nearest scrollable ancestor) to local bounds (which are relative
// to the top of the web accessibility tree).
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698