Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1198193006: Revert "Revert "Android: Store language .pak files in res/raw rather than assets"" (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, lcwu+watch_chromium.org, jam, android-webview-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, gunsch+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert "Android: Store language .pak files in res/raw rather than assets"" This reverts commit bd0057ca4ca5990173e099f5cdd5219c6ed72fd5. Also adds a "setMandatoryPaksToExtract" overload to prevent breakage. BUG=371610 TBR=Yaron, Torne, cjhopman, Jaekyun Seok, James Hawkins, gunsch, newt Committed: https://crrev.com/1e54fed611ebeef569a3c452f744ed53ae341991 Cr-Commit-Position: refs/heads/master@{#335538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -186 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java View 1 chunk +1 line, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 9 chunks +98 lines, -121 lines 0 comments Download
A build/android/gyp/locale_pak_resources.py View 1 chunk +97 lines, -0 lines 0 comments Download
A build/android/locale_pak_resources.gypi View 1 chunk +52 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 4 chunks +20 lines, -9 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/chrome_android_paks.gypi View 2 chunks +2 lines, -44 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
agrieve
TBR'ing a re-land with a setMandatoryPaksToExtract() overload to not break webview
5 years, 6 months ago (2015-06-22 17:39:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198193006/1
5 years, 6 months ago (2015-06-22 17:48:15 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-22 17:48:19 UTC) #6
gunsch
can you fix the bug number? (otherwise, rs lgtm for the reland)
5 years, 6 months ago (2015-06-22 17:49:28 UTC) #7
agrieve
On 2015/06/22 17:49:28, gunsch wrote: > can you fix the bug number? > > (otherwise, ...
5 years, 6 months ago (2015-06-22 17:54:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198193006/1
5 years, 6 months ago (2015-06-22 17:55:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 19:02:02 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 19:03:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e54fed611ebeef569a3c452f744ed53ae341991
Cr-Commit-Position: refs/heads/master@{#335538}

Powered by Google App Engine
This is Rietveld 408576698