Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: Source/core/input/EventHandler.h

Issue 1198193005: Fixed memory issues with EventHandler::TouchInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/input/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/input/EventHandler.h
diff --git a/Source/core/input/EventHandler.h b/Source/core/input/EventHandler.h
index 5a131309cfaf097de2b1e70ea11a8e3b9d0d60a2..ce962a870f5a5106c801faf72defe4b28807f4a0 100644
--- a/Source/core/input/EventHandler.h
+++ b/Source/core/input/EventHandler.h
@@ -320,7 +320,7 @@ private:
using TouchInfo = struct {
haraken 2015/06/22 23:40:35 class TouchInfo { ALLOW_ONLY_INLINE_ALLOCATION()
mustaq 2015/06/23 15:25:51 Done, but kept the pointer to LocalFrame as is bec
sof 2015/06/23 15:57:34 It ought to work fine as suggested; could you expl
mustaq 2015/06/23 16:36:27 I kept the LocalFrame* as is because from this pie
sof 2015/06/23 18:52:02 Yes, it probably isn't worth adding a RefPtr<> her
mustaq 2015/06/24 14:47:52 Okay, switched away from raw ptr for LocalFrame.
PlatformTouchPoint point;
- EventTarget* touchTarget;
+ RefPtrWillBeMember<EventTarget> touchTarget;
LocalFrame* targetFrame;
FloatPoint adjustedPagePoint;
FloatSize adjustedRadius;
« no previous file with comments | « no previous file | Source/core/input/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698