Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 119803002: Add GN conversions for more GYP flags (Closed)

Created:
7 years ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Add GN conversions for flags Adds a remapping from important GYP flags used on the main waterfall for GN. For the other ones, I added a list of used flags and filed bugs for them. R=scottmg@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242356

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
M build/config/BUILDCONFIG.gn View 1 2 3 chunks +19 lines, -1 line 0 comments Download
M build/gyp_chromium View 1 2 chunks +25 lines, -0 lines 1 comment Download
M build/toolchain/mac/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/skia/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/third_party/libxml/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
7 years ago (2013-12-20 06:06:26 UTC) #1
scottmg
lgtm
7 years ago (2013-12-20 17:02:16 UTC) #2
scottmg
ps2 otherwise lgtm https://codereview.chromium.org/119803002/diff/30001/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/119803002/diff/30001/build/config/BUILDCONFIG.gn#newcode297 build/config/BUILDCONFIG.gn:297: if (!is_clang && !is_win && (is_asan ...
7 years ago (2013-12-20 22:03:37 UTC) #3
brettw
On 2013/12/20 22:03:37, scottmg OoO Dec21-Jan5 wrote: > ps2 otherwise lgtm > > https://codereview.chromium.org/119803002/diff/30001/build/config/BUILDCONFIG.gn > ...
7 years ago (2013-12-20 22:05:38 UTC) #4
brettw
Committed patchset #5 manually as r242356 (presubmit successful).
7 years ago (2013-12-23 05:12:07 UTC) #5
Nico
6 years, 10 months ago (2014-02-10 22:04:14 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/119803002/diff/420001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/119803002/diff/420001/build/gyp_chromium#newc...
build/gyp_chromium:122: #   host_os=linux  Probably can skip, GN knows the host
OS.
(This is used by the android webview build, which apparently uses this define to
create mac-hosted makefiles while gypping on linux.)

Powered by Google App Engine
This is Rietveld 408576698