Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1197963003: Remove old iOS porting files. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 5 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove old iOS porting files. These files do not appear to be used, are unfinished, and should be redundant with the mac porting files. Committed: https://skia.googlesource.com/skia/+/3fdde4e129f43b9d2f0c31a791ebe17ff06e4612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -514 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/iOSShell.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D include/utils/ios/SkStream_NSData.h View 1 chunk +0 lines, -41 lines 0 comments Download
D src/utils/ios/SkFontHost_iOS.mm View 1 chunk +0 lines, -262 lines 0 comments Download
D src/utils/ios/SkImageDecoder_iOS.mm View 1 chunk +0 lines, -65 lines 0 comments Download
D src/utils/ios/SkOSFile_iOS.mm View 1 chunk +0 lines, -98 lines 0 comments Download
D src/utils/ios/SkStream_NSData.mm View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197963003/1
5 years, 6 months ago (2015-06-22 18:14:58 UTC) #2
bungeman-skia
5 years, 6 months ago (2015-06-22 18:17:40 UTC) #4
mtklein
lgtm
5 years, 6 months ago (2015-06-22 18:19:18 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-22 18:19:51 UTC) #7
bungeman-skia
Just wanted to point out that iOS should be (and is) using the equivalent '_mac' ...
5 years, 6 months ago (2015-06-22 18:24:08 UTC) #8
reed1
lgtm
5 years, 5 months ago (2015-06-29 20:45:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197963003/1
5 years, 5 months ago (2015-06-29 21:00:46 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 21:12:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3fdde4e129f43b9d2f0c31a791ebe17ff06e4612

Powered by Google App Engine
This is Rietveld 408576698