Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 119793002: SyncFS: Fix when to call OnSyncIdle() (Closed)

Created:
7 years ago by kinuko
Modified:
7 years ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

SyncFS: Fix when to call OnSyncIdle() Without this fix demoted changes are not correctly promoted BUG=330116, 240165 TEST=manual with logging (update - delete conflict) R=nhiroki@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/sync_file_system/sync_process_runner.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Sorry, very silly bug. PTL
7 years ago (2013-12-20 05:58:35 UTC) #1
kinuko
+nhiroki can you take a look?
7 years ago (2013-12-20 06:23:17 UTC) #2
nhiroki
lgtm
7 years ago (2013-12-20 06:26:55 UTC) #3
tzik
lgtm
7 years ago (2013-12-20 06:27:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/119793002/1
7 years ago (2013-12-20 07:23:17 UTC) #5
kinuko
7 years ago (2013-12-20 10:25:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r242059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698