Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1197913002: Test262-es6 test runner should handle sloppy fail better (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
CC:
v8-dev, Jakob Kummerow
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Test262-es6 test runner should handle sloppy fail better This adds a new FAIL_SLOPPY expected output. It then uses this to determine if the test case has unexpected output. BUG=v8:4164 LOG=N R=machenbach@chromium.org Committed: https://crrev.com/9f550240b03f2894ec97d6b304d1445916b9b26c Cr-Commit-Position: refs/heads/master@{#29194}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M test/test262-es6/test262-es6.status View 1 chunk +21 lines, -3 lines 0 comments Download
M test/test262-es6/testcfg.py View 1 2 chunks +8 lines, -0 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
arv (Not doing code reviews)
PTAL Is this too hacky? If not I'll update more of the status file in ...
5 years, 6 months ago (2015-06-19 21:23:34 UTC) #1
Michael Achenbach
LGTM. This degree of hackiness is ok, since it is rather local to test262-es6.
5 years, 6 months ago (2015-06-22 07:03:43 UTC) #2
Jakob Kummerow
ACK. https://codereview.chromium.org/1197913002/diff/1/test/test262-es6/testcfg.py File test/test262-es6/testcfg.py (right): https://codereview.chromium.org/1197913002/diff/1/test/test262-es6/testcfg.py#newcode142 test/test262-es6/testcfg.py:142: if (statusfile.FAIL_SLOPPY in testcase.outcomes and "--use-strict" not in ...
5 years, 6 months ago (2015-06-22 08:12:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197913002/20001
5 years, 6 months ago (2015-06-22 14:44:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 15:08:39 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 15:09:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f550240b03f2894ec97d6b304d1445916b9b26c
Cr-Commit-Position: refs/heads/master@{#29194}

Powered by Google App Engine
This is Rietveld 408576698