src/IceFixups.cpp - Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceFixups.cpp

Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Use constexpr inline functions instead of macros Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceFixups.cpp

diff --git a/src/IceFixups.cpp b/src/IceFixups.cpp

index b6adf8450282032cc94fab514f43139f6f4939b5..468fa3d3b4b6f73dbac6b5c757a7564b82c031ce 100644

--- a/src/IceFixups.cpp

+++ b/src/IceFixups.cpp

@@ -47,7 +47,7 @@ IceString AssemblerFixup::symbol(const GlobalContext *Ctx) const {

}

void AssemblerFixup::emit(GlobalContext *Ctx, RelocOffsetT BaseOffset) const {

- if (!ALLOW_DUMP)

+ if (!buildAllowsDump())

return;

Ostream &Str = Ctx->getStrEmit();

if (isNullSymbol())

« src/IceDefs.h ('K') | « src/IceDefs.h ('k') | src/IceGlobalContext.h » ('j') | no next file with comments »