src/IceGlobalInits.h - Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalInits.h

Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Cleanup Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceGlobalInits.h

diff --git a/src/IceGlobalInits.h b/src/IceGlobalInits.h

index cd66500362742f4fdc96b56026aec7a5ae3d8c13..387c0e3399886cdbeae61fc63e142bdfba976d71 100644

--- a/src/IceGlobalInits.h

+++ b/src/IceGlobalInits.h

@@ -66,7 +66,7 @@ public:

/// Prints out the global declaration.

virtual void dump(GlobalContext *Ctx, Ostream &Stream) const = 0;

void dump(Ostream &Stream) const {

- if (!ALLOW_DUMP)

+ if (!BuildDefs::dump())

return;

GlobalContext *const Ctx = nullptr;

dump(Ctx, Stream);

@@ -153,7 +153,7 @@ public:

virtual SizeT getNumBytes() const = 0;

virtual void dump(GlobalContext *Ctx, Ostream &Stream) const = 0;

void dump(Ostream &Stream) const {

- if (ALLOW_DUMP)

+ if (BuildDefs::dump())

dump(nullptr, Stream);

}

virtual void dumpType(Ostream &Stream) const;

« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceGlobalInits.cpp » ('j') | no next file with comments »