src/IceConverter.cpp - Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceConverter.cpp

Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Cleanup Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceConverter.cpp

diff --git a/src/IceConverter.cpp b/src/IceConverter.cpp

index baa8eeb13384dd0ac5bbb8d1f8ba3a4856c83bfa..afffb9958c85af668821dc1fa8e0354e447b48b2 100644

--- a/src/IceConverter.cpp

+++ b/src/IceConverter.cpp

@@ -167,7 +167,7 @@ private:

return nullptr;

if (VarMap.find(V) == VarMap.end()) {

VarMap[V] = Func->makeVariable(IceTy);

- if (ALLOW_DUMP)

+ if (Ice::BuildDefs::dump())

VarMap[V]->setName(Func.get(), V->getName());

}

return VarMap[V];

@@ -180,7 +180,7 @@ private:

Ice::CfgNode *mapBasicBlockToNode(const BasicBlock *BB) {

if (NodeMap.find(BB) == NodeMap.end()) {

NodeMap[BB] = Func->makeNode();

- if (ALLOW_DUMP)

+ if (Ice::BuildDefs::dump())

NodeMap[BB]->setName(BB->getName());

}

return NodeMap[BB];

« no previous file with comments | « src/IceCompiler.cpp ('k') | src/IceDefs.h » ('j') | no next file with comments »