Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: src/IceClFlags.h

Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Cleanup Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceCfgNode.cpp ('k') | src/IceClFlags.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceClFlags.h
diff --git a/src/IceClFlags.h b/src/IceClFlags.h
index 3b9b0067601d54600902de4ca5dead4be7fa563d..b677e1c1b746936b426f8625dab10290fdfa5fa3 100644
--- a/src/IceClFlags.h
+++ b/src/IceClFlags.h
@@ -55,14 +55,14 @@ public:
void setDisableInternal(bool NewValue) { DisableInternal = NewValue; }
bool getDisableIRGeneration() const {
- return ALLOW_DISABLE_IR_GEN && DisableIRGeneration;
+ return BuildDefs::disableIrGen() && DisableIRGeneration;
}
void setDisableIRGeneration(bool NewValue) { DisableIRGeneration = NewValue; }
bool getDisableTranslation() const { return DisableTranslation; }
void setDisableTranslation(bool NewValue) { DisableTranslation = NewValue; }
- bool getDumpStats() const { return ALLOW_DUMP && DumpStats; }
+ bool getDumpStats() const { return BuildDefs::dump() && DumpStats; }
void setDumpStats(bool NewValue) { DumpStats = NewValue; }
bool getEnableBlockProfile() const { return EnableBlockProfile; }
@@ -74,7 +74,7 @@ public:
bool getGenerateUnitTestMessages() const {
// Note: If dump routines have been turned off, the error messages
// will not be readable. Hence, turn off.
- return !ALLOW_DUMP || GenerateUnitTestMessages;
+ return !BuildDefs::dump() || GenerateUnitTestMessages;
}
void setGenerateUnitTestMessages(bool NewValue) {
GenerateUnitTestMessages = NewValue;
@@ -97,7 +97,9 @@ public:
SubzeroTimingEnabled = NewValue;
}
- bool getTimeEachFunction() const { return ALLOW_DUMP && TimeEachFunction; }
+ bool getTimeEachFunction() const {
+ return BuildDefs::dump() && TimeEachFunction;
+ }
void setTimeEachFunction(bool NewValue) { TimeEachFunction = NewValue; }
bool getUseSandboxing() const { return UseSandboxing; }
@@ -131,7 +133,7 @@ public:
}
VerboseMask getVerbose() const {
- return ALLOW_DUMP ? VMask : (VerboseMask)IceV_None;
+ return BuildDefs::dump() ? VMask : (VerboseMask)IceV_None;
}
void setVerbose(VerboseMask NewValue) { VMask = NewValue; }
« no previous file with comments | « src/IceCfgNode.cpp ('k') | src/IceClFlags.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698