Subzero: Reduce the amount of #ifdef'd code.

src/IceInstARM32.cpp

 //===- subzero/src/IceInstARM32.cpp - ARM32 instruction implementation ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the InstARM32 and OperandARM32 classes,
@@ skipping 79 matching lines @@
   if (SrcTy != DestTy)
     Str << getWidthString(SrcTy);
   Str << "\t";
   Inst->getDest()->emit(Func);
   Str << ", ";
   Inst->getSrc(0)->emit(Func);
 }
 
 void InstARM32Pred::emitTwoAddr(const char *Opcode, const InstARM32Pred *Inst,
                                 const Cfg *Func) {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(Inst->getSrcSize() == 2);
   Variable *Dest = Inst->getDest();
   assert(Dest == Inst->getSrc(0));
   Str << "\t" << Opcode << Inst->getPredicate() << "\t";
   Dest->emit(Func);
   Str << ", ";
   Inst->getSrc(1)->emit(Func);
 }
 
 void InstARM32Pred::emitThreeAddr(const char *Opcode, const InstARM32Pred *Inst,
                                   const Cfg *Func, bool SetFlags) {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(Inst->getSrcSize() == 2);
   Str << "\t" << Opcode << (SetFlags ? "s" : "") << Inst->getPredicate()
       << "\t";
   Inst->getDest()->emit(Func);
   Str << ", ";
   Inst->getSrc(0)->emit(Func);
   Str << ", ";
   Inst->getSrc(1)->emit(Func);
@@ skipping 218 matching lines @@
 template <> const char *InstARM32Eor::Opcode = "eor";
 template <> const char *InstARM32Lsl::Opcode = "lsl";
 template <> const char *InstARM32Lsr::Opcode = "lsr";
 template <> const char *InstARM32Mul::Opcode = "mul";
 template <> const char *InstARM32Orr::Opcode = "orr";
 template <> const char *InstARM32Rsb::Opcode = "rsb";
 template <> const char *InstARM32Sbc::Opcode = "sbc";
 template <> const char *InstARM32Sub::Opcode = "sub";
 
 void InstARM32::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   Str << "[ARM32] ";
   Inst::dump(Func);
 }
 
 template <> void InstARM32Mov::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 1);
   Variable *Dest = getDest();
   if (Dest->hasReg()) {
     IceString Opcode = "mov";
     Operand *Src0 = getSrc(0);
     if (const auto *Src0V = llvm::dyn_cast<Variable>(Src0)) {
       if (!Src0V->hasReg()) {
         Opcode = IceString("ldr"); // Always use the whole stack slot.
@@ skipping 17 matching lines @@
   }
 }
 
 template <> void InstARM32Mov::emitIAS(const Cfg *Func) const {
   assert(getSrcSize() == 1);
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Br::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "\t"
       << "b" << getPredicate() << "\t";
   if (isUnconditionalBranch()) {
     Str << getTargetFalse()->getAsmName();
   } else {
     Str << getTargetTrue()->getAsmName();
     if (getTargetFalse()) {
       Str << "\n\t"
           << "b"
           << "\t" << getTargetFalse()->getAsmName();
     }
   }
 }
 
 void InstARM32Br::emitIAS(const Cfg *Func) const {
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Br::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   Str << "br ";
 
   if (getPredicate() == CondARM32::AL) {
     Str << "label %" << getTargetFalse()->getName();
     return;
   }
 
   Str << getPredicate() << ", label %" << getTargetTrue()->getName();
   if (getTargetFalse()) {
     Str << ", label %" << getTargetFalse()->getName();
   }
 }
 
 void InstARM32Call::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 1);
   if (llvm::isa<ConstantInteger32>(getCallTarget())) {
     // This shouldn't happen (typically have to copy the full 32-bits
     // to a register and do an indirect jump).
     llvm::report_fatal_error("ARM32Call to ConstantInteger32");
   } else if (const auto CallTarget =
                  llvm::dyn_cast<ConstantRelocatable>(getCallTarget())) {
     // Calls only have 24-bits, but the linker should insert veneers to
@@ skipping 10 matching lines @@
   }
   Func->getTarget()->resetStackAdjustment();
 }
 
 void InstARM32Call::emitIAS(const Cfg *Func) const {
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Call::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   if (getDest()) {
     dumpDest(Func);
     Str << " = ";
   }
   Str << "call ";
   getCallTarget()->dump(Func);
 }
 
 void InstARM32Cmp::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 2);
   Str << "\t"
       << "cmp" << getPredicate() << "\t";
   getSrc(0)->emit(Func);
   Str << ", ";
   getSrc(1)->emit(Func);
 }
 
 void InstARM32Cmp::emitIAS(const Cfg *Func) const {
   assert(getSrcSize() == 2);
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Cmp::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   dumpOpcodePred(Str, "cmp", getSrc(0)->getType());
   dumpSources(Func);
 }
 
 void InstARM32Ldr::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 1);
   assert(getDest()->hasReg());
   Type Ty = getSrc(0)->getType();
   Str << "\t"
       << "ldr" << getWidthString(Ty) << getPredicate() << "\t";
   getDest()->emit(Func);
   Str << ", ";
   getSrc(0)->emit(Func);
 }
 
 void InstARM32Ldr::emitIAS(const Cfg *Func) const {
   assert(getSrcSize() == 1);
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Ldr::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   dumpDest(Func);
   Str << " = ";
   dumpOpcodePred(Str, "ldr", getDest()->getType());
   Str << " ";
   dumpSources(Func);
 }
 
 void InstARM32Mla::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 3);
   assert(getDest()->hasReg());
   Str << "\t"
       << "mla" << getPredicate() << "\t";
   getDest()->emit(Func);
   Str << ", ";
   getSrc(0)->emit(Func);
   Str << ", ";
   getSrc(1)->emit(Func);
   Str << ", ";
   getSrc(2)->emit(Func);
 }
 
 void InstARM32Mla::emitIAS(const Cfg *Func) const {
   assert(getSrcSize() == 3);
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Mla::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   dumpDest(Func);
   Str << " = ";
   dumpOpcodePred(Str, "mla", getDest()->getType());
   Str << " ";
   dumpSources(Func);
 }
 
 template <> void InstARM32Movw::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 1);
   Str << "\t" << Opcode << getPredicate() << "\t";
   getDest()->emit(Func);
   Str << ", ";
   Constant *Src0 = llvm::cast<Constant>(getSrc(0));
   if (auto CR = llvm::dyn_cast<ConstantRelocatable>(Src0)) {
     Str << "#:lower16:";
     CR->emitWithoutPrefix(Func->getTarget());
   } else {
     Src0->emit(Func);
   }
 }
 
 template <> void InstARM32Movt::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 2);
   Variable *Dest = getDest();
   Constant *Src1 = llvm::cast<Constant>(getSrc(1));
   Str << "\t" << Opcode << getPredicate() << "\t";
   Dest->emit(Func);
   Str << ", ";
   if (auto CR = llvm::dyn_cast<ConstantRelocatable>(Src1)) {
     Str << "#:upper16:";
     CR->emitWithoutPrefix(Func->getTarget());
   } else {
     Src1->emit(Func);
   }
 }
 
 void InstARM32Pop::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   assert(Dests.size() > 0);
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "\t"
       << "pop"
       << "\t{";
   for (SizeT I = 0; I < Dests.size(); ++I) {
     if (I > 0)
       Str << ", ";
     Dests[I]->emit(Func);
   }
   Str << "}";
 }
 
 void InstARM32Pop::emitIAS(const Cfg *Func) const {
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Pop::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   Str << "pop"
       << " ";
   for (SizeT I = 0; I < Dests.size(); ++I) {
     if (I > 0)
       Str << ", ";
     Dests[I]->dump(Func);
   }
 }
 
 void InstARM32AdjustStack::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 2);
   Str << "\t"
       << "sub"
       << "\t";
   getDest()->emit(Func);
   Str << ", ";
   getSrc(0)->emit(Func);
   Str << ", ";
   getSrc(1)->emit(Func);
   Func->getTarget()->updateStackAdjustment(Amount);
 }
 
 void InstARM32AdjustStack::emitIAS(const Cfg *Func) const {
   (void)Func;
   llvm_unreachable("Not yet implemented");
   Func->getTarget()->updateStackAdjustment(Amount);
 }
 
 void InstARM32AdjustStack::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   getDest()->dump(Func);
   Str << " = sub.i32 ";
   getSrc(0)->dump(Func);
   Str << ", " << Amount << " ; ";
   getSrc(1)->dump(Func);
 }
 
 void InstARM32Push::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   assert(getSrcSize() > 0);
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "\t"
       << "push"
       << "\t{";
   emitSources(Func);
   Str << "}";
 }
 
 void InstARM32Push::emitIAS(const Cfg *Func) const {
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Push::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   Str << "push"
       << " ";
   dumpSources(Func);
 }
 
 void InstARM32Ret::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   assert(getSrcSize() > 0);
   Variable *LR = llvm::cast<Variable>(getSrc(0));
   assert(LR->hasReg());
   assert(LR->getRegNum() == RegARM32::Reg_lr);
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "\t"
       << "bx"
       << "\t";
   LR->emit(Func);
 }
 
 void InstARM32Ret::emitIAS(const Cfg *Func) const {
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Ret::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   Type Ty = (getSrcSize() == 1 ? IceType_void : getSrc(0)->getType());
   Str << "ret." << Ty << " ";
   dumpSources(Func);
 }
 
 void InstARM32Str::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 2);
   Type Ty = getSrc(0)->getType();
   Str << "\t"
       << "str" << getWidthString(Ty) << getPredicate() << "\t";
   getSrc(0)->emit(Func);
   Str << ", ";
   getSrc(1)->emit(Func);
 }
 
 void InstARM32Str::emitIAS(const Cfg *Func) const {
   assert(getSrcSize() == 2);
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Str::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   Type Ty = getSrc(0)->getType();
   dumpOpcodePred(Str, "str", Ty);
   Str << " ";
   getSrc(1)->dump(Func);
   Str << ", ";
   getSrc(0)->dump(Func);
 }
 
 void InstARM32Umull::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   assert(getSrcSize() == 2);
   assert(getDest()->hasReg());
   Str << "\t"
       << "umull" << getPredicate() << "\t";
   getDest()->emit(Func);
   Str << ", ";
   DestHi->emit(Func);
   Str << ", ";
   getSrc(0)->emit(Func);
   Str << ", ";
   getSrc(1)->emit(Func);
 }
 
 void InstARM32Umull::emitIAS(const Cfg *Func) const {
   assert(getSrcSize() == 2);
   (void)Func;
   llvm_unreachable("Not yet implemented");
 }
 
 void InstARM32Umull::dump(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrDump();
   dumpDest(Func);
   Str << " = ";
   dumpOpcodePred(Str, "umull", getDest()->getType());
   Str << " ";
   dumpSources(Func);
 }
 
 void OperandARM32Mem::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   Str << "[";
   getBase()->emit(Func);
   switch (getAddrMode()) {
   case PostIndex:
   case NegPostIndex:
     Str << "], ";
     break;
   default:
@@ skipping 22 matching lines @@
     Str << "]!";
     break;
   case PostIndex:
   case NegPostIndex:
     // Brace is already closed off.
     break;
   }
 }
 
 void OperandARM32Mem::dump(const Cfg *Func, Ostream &Str) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Str << "[";
   if (Func)
     getBase()->dump(Func);
   else
     getBase()->dump(Str);
   Str << ", ";
   if (isRegReg()) {
     if (isNegAddrMode()) {
       Str << "-";
     }
     if (Func)
       getIndex()->dump(Func);
     else
       getIndex()->dump(Str);
     if (getShiftOp() != kNoShift) {
       Str << ", " << InstARM32ShiftAttributes[getShiftOp()].EmitString << " #"
           << getShiftAmt();
     }
   } else {
     getOffset()->dump(Func, Str);
   }
   Str << "] AddrMode==" << getAddrMode();
 }
 
 void OperandARM32FlexImm::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   uint32_t Imm = getImm();
   uint32_t RotateAmt = getRotateAmt();
   Str << "#" << Utils::rotateRight32(Imm, 2 * RotateAmt);
 }
 
 void OperandARM32FlexImm::dump(const Cfg * /* Func */, Ostream &Str) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   uint32_t Imm = getImm();
   uint32_t RotateAmt = getRotateAmt();
   Str << "#(" << Imm << " ror 2*" << RotateAmt << ")";
 }
 
 void OperandARM32FlexReg::emit(const Cfg *Func) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   getReg()->emit(Func);
   if (getShiftOp() != kNoShift) {
     Str << ", " << InstARM32ShiftAttributes[getShiftOp()].EmitString << " ";
     getShiftAmt()->emit(Func);
   }
 }
 
 void OperandARM32FlexReg::dump(const Cfg *Func, Ostream &Str) const {
-  if (!ALLOW_DUMP)
+  if (!buildAllowsDump())
     return;
   Variable *Reg = getReg();
   if (Func)
     Reg->dump(Func);
   else
     Reg->dump(Str);
   if (getShiftOp() != kNoShift) {
     Str << ", " << InstARM32ShiftAttributes[getShiftOp()].EmitString << " ";
     if (Func)
       getShiftAmt()->dump(Func);
     else
       getShiftAmt()->dump(Str);
   }
 }
 
 } // end of namespace Ice