Subzero: Reduce the amount of #ifdef'd code.

src/IceDefs.h

 //===- subzero/src/IceDefs.h - Common Subzero declaraions -------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares various useful types and classes that have
@@ skipping 27 matching lines @@
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/Support/Allocator.h"
 #include "llvm/Support/Casting.h"
 #include "llvm/Support/ELF.h"
 #include "llvm/Support/raw_ostream.h"
 
 #include "IceTLS.h"
 
 namespace Ice {
 
+constexpr bool buildAllowsAsserts() {

[John, 2015/06/23 22:28:30]

optional: As we spoke during our walk back, it seems these functions are all
part of

namespace BuildAllows {
...
}

[Jim Stichnoth, 2015/06/24 21:27:27]

Done.  I went with BuildDefs::asserts(), and similar for all the other defines
where that was practical.

+#ifdef NDEBUG

[John, 2015/06/23 22:28:30]

This is a bit surprising to me. I always though

-DNDEBUG=0

would turn asserts on... oh, the wonders of C. :)

[Jim Stichnoth, 2015/06/24 21:27:27]

Yep, NDEBUG is either defined or not, and its value matters not...

+  return false;
+#else // !NDEBUG
+  return true;
+#endif // !NDEBUG
+}
+
+constexpr bool buildAllowsExtraValidation() {
+#ifdef ALLOW_EXTRA_VALIDATION

[John, 2015/06/23 22:28:30]

probably just

#if ALLOW_EXTRA_VALIDATION

?

Otherwise,

-DALLOW_EXTRA_VALIDATION=0

will cause extra validation to be allowed.

[Jim Stichnoth, 2015/06/24 21:27:27]

Done.

+  return true;
+#else // !ALLOW_EXTRA_VALIDATION
+  return false;
+#endif // !ALLOW_EXTRA_VALIDATION
+}
+
+constexpr bool buildAllowsDump() {
+#if defined(ALLOW_DUMP) && ALLOW_DUMP

[John, 2015/06/23 22:28:30]

this can be simply

#if ALLOW_DUMP

(see  https://gcc.gnu.org/onlinedocs/gcc-3.0.2/cpp_4.html)

[Jim Stichnoth, 2015/06/24 21:27:27]

Done.

+  return true;
+#else // !ALLOW_DUMP
+  return false;
+#endif // !ALLOW_DUMP
+}
+
 class Assembler;
 class Cfg;
 class CfgNode;
 class Constant;
 class ELFObjectWriter;
 class ELFStreamer;
 class FunctionDeclaration;
 class GlobalContext;
 class GlobalDeclaration;
 class Inst;
@@ skipping 206 matching lines @@
 llvm::iterator_range<typename T::reverse_iterator> reverse_range(T &Container) {
   return llvm::make_range(Container.rbegin(), Container.rend());
 }
 
 // Options for pooling and randomization of immediates
 enum RandomizeAndPoolImmediatesEnum { RPI_None, RPI_Randomize, RPI_Pool };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEDEFS_H