Subzero: Reduce the amount of #ifdef'd code.

src/IceGlobalContext.h

 //===- subzero/src/IceGlobalContext.h - Global context defs -----*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares aspects of the compilation that persist across
@@ skipping 97 matching lines @@
     TimerList(const TimerList &) = delete;
     TimerList &operator=(const TimerList &) = delete;
 
   public:
     TimerList() = default;
     // initInto() initializes a target list of timers based on the
     // current list.  In particular, it creates the same number of
     // timers, in the same order, with the same names, but initially
     // empty of timing data.
     void initInto(TimerList &Dest) const {
-      if (!ALLOW_DUMP)
+      if (!BuildDefs::dump())
         return;
       Dest.clear();
       for (const TimerStack &Stack : *this) {
         Dest.push_back(TimerStack(Stack.getName()));
       }
     }
     void mergeFrom(TimerList &Src) {
-      if (!ALLOW_DUMP)
+      if (!BuildDefs::dump())
         return;
       assert(size() == Src.size());
       size_type i = 0;
       for (TimerStack &Stack : *this) {
         assert(Stack.getName() == Src[i].getName());
         Stack.mergeFrom(Src[i]);
         ++i;
       }
     }
   };
@@ skipping 99 matching lines @@
   const Intrinsics &getIntrinsicsInfo() const { return IntrinsicsInfo; }
 
   // TODO(wala,stichnot): Make the RNG play nicely with multithreaded
   // translation.
   RandomNumberGenerator &getRNG() { return RNG; }
 
   ELFObjectWriter *getObjectWriter() const { return ObjectWriter.get(); }
 
   // Reset stats at the beginning of a function.
   void resetStats() {
-    if (ALLOW_DUMP)
+    if (BuildDefs::dump())
       ICE_TLS_GET_FIELD(TLS)->StatsFunction.reset();
   }
   void dumpStats(const IceString &Name, bool Final = false);
   void statsUpdateEmitted(uint32_t InstCount) {
     if (!getFlags().getDumpStats())
       return;
     ThreadContext *Tls = ICE_TLS_GET_FIELD(TLS);
     Tls->StatsFunction.update(CodeStats::CS_InstCount, InstCount);
     Tls->StatsCumulative.update(CodeStats::CS_InstCount, InstCount);
   }
@@ skipping 116 matching lines @@
     TranslationThreads.clear();
 
     // Only notify the emit queue to end after all the translation
     // threads have ended.
     emitQueueNotifyEnd();
     for (std::thread &Worker : EmitterThreads) {
       Worker.join();
     }
     EmitterThreads.clear();
 
-    if (ALLOW_DUMP) {
+    if (BuildDefs::dump()) {
       auto Timers = getTimers();
       for (ThreadContext *TLS : AllThreadContexts)
         Timers->mergeFrom(TLS->Timers);
     }
-    if (ALLOW_DUMP) {
+    if (BuildDefs::dump()) {
       // Do a separate loop over AllThreadContexts to avoid holding
       // two locks at once.
       auto Stats = getStatsCumulative();
       for (ThreadContext *TLS : AllThreadContexts)
         Stats->add(TLS->StatsCumulative);
     }
   }
 
   // Translation thread startup routine.
   void translateFunctionsWrapper(ThreadContext *MyTLS) {
@@ skipping 154 matching lines @@
 // convenient timing of regions of code.
 class TimerMarker {
   TimerMarker() = delete;
   TimerMarker(const TimerMarker &) = delete;
   TimerMarker &operator=(const TimerMarker &) = delete;
 
 public:
   TimerMarker(TimerIdT ID, GlobalContext *Ctx,
               TimerStackIdT StackID = GlobalContext::TSK_Default)
       : ID(ID), Ctx(Ctx), StackID(StackID) {
-    if (ALLOW_DUMP)
+    if (BuildDefs::dump())
       push();
   }
   TimerMarker(TimerIdT ID, const Cfg *Func,
               TimerStackIdT StackID = GlobalContext::TSK_Default)
       : ID(ID), Ctx(nullptr), StackID(StackID) {
     // Ctx gets set at the beginning of pushCfg().
-    if (ALLOW_DUMP)
+    if (BuildDefs::dump())
       pushCfg(Func);
   }
 
   ~TimerMarker() {
-    if (ALLOW_DUMP && Active)
+    if (BuildDefs::dump() && Active)
       Ctx->popTimer(ID, StackID);
   }
 
 private:
   void push();
   void pushCfg(const Cfg *Func);
   const TimerIdT ID;
   GlobalContext *Ctx;
   const TimerStackIdT StackID;
   bool Active = false;
@@ skipping 11 matching lines @@
   explicit OstreamLocker(GlobalContext *Ctx) : Ctx(Ctx) { Ctx->lockStr(); }
   ~OstreamLocker() { Ctx->unlockStr(); }
 
 private:
   GlobalContext *const Ctx;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEGLOBALCONTEXT_H