Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/IceELFObjectWriter.cpp

Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Cleanup Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceDefs.h ('k') | src/IceFixups.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceELFObjectWriter.cpp - ELF object file writer --------===// 1 //===- subzero/src/IceELFObjectWriter.cpp - ELF object file writer --------===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file defines the writer for ELF relocatable object files. 10 // This file defines the writer for ELF relocatable object files.
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 if (ST == ROData) 383 if (ST == ROData)
384 Section->appendZeros(Str, SymbolSize); 384 Section->appendZeros(Str, SymbolSize);
385 else 385 else
386 Section->setSize(Section->getCurrentSize() + SymbolSize); 386 Section->setSize(Section->getCurrentSize() + SymbolSize);
387 } else { 387 } else {
388 assert(ST != BSS); 388 assert(ST != BSS);
389 for (const std::unique_ptr<VariableDeclaration::Initializer> &Init : 389 for (const std::unique_ptr<VariableDeclaration::Initializer> &Init :
390 Var->getInitializers()) { 390 Var->getInitializers()) {
391 switch (Init->getKind()) { 391 switch (Init->getKind()) {
392 case VariableDeclaration::Initializer::DataInitializerKind: { 392 case VariableDeclaration::Initializer::DataInitializerKind: {
393 const auto Data = llvm::cast<VariableDeclaration::DataInitializer>( 393 const auto Data =
394 Init.get())->getContents(); 394 llvm::cast<VariableDeclaration::DataInitializer>(Init.get())
395 ->getContents();
395 Section->appendData(Str, llvm::StringRef(Data.data(), Data.size())); 396 Section->appendData(Str, llvm::StringRef(Data.data(), Data.size()));
396 break; 397 break;
397 } 398 }
398 case VariableDeclaration::Initializer::ZeroInitializerKind: 399 case VariableDeclaration::Initializer::ZeroInitializerKind:
399 Section->appendZeros(Str, Init->getNumBytes()); 400 Section->appendZeros(Str, Init->getNumBytes());
400 break; 401 break;
401 case VariableDeclaration::Initializer::RelocInitializerKind: { 402 case VariableDeclaration::Initializer::RelocInitializerKind: {
402 const auto Reloc = 403 const auto Reloc =
403 llvm::cast<VariableDeclaration::RelocInitializer>(Init.get()); 404 llvm::cast<VariableDeclaration::RelocInitializer>(Init.get());
404 AssemblerFixup NewFixup; 405 AssemblerFixup NewFixup;
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 if (ELF64) { 618 if (ELF64) {
618 writeELFHeaderInternal<true>(ShOffset, ShStrTab->getNumber(), 619 writeELFHeaderInternal<true>(ShOffset, ShStrTab->getNumber(),
619 AllSections.size()); 620 AllSections.size());
620 } else { 621 } else {
621 writeELFHeaderInternal<false>(ShOffset, ShStrTab->getNumber(), 622 writeELFHeaderInternal<false>(ShOffset, ShStrTab->getNumber(),
622 AllSections.size()); 623 AllSections.size());
623 } 624 }
624 } 625 }
625 626
626 } // end of namespace Ice 627 } // end of namespace Ice
OLDNEW
« no previous file with comments | « src/IceDefs.h ('k') | src/IceFixups.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698