Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: chrome/browser/content_settings/permission_context_uma_util.h

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleaned up text and removed GetOrigin DCHECK. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_context_uma_util.h
diff --git a/chrome/browser/content_settings/permission_context_uma_util.h b/chrome/browser/content_settings/permission_context_uma_util.h
index 8d769aeb2268f5192a963f2b755a0bd522c625a8..4a148ba1b15fb86412abe9ec2ab3830f55041763 100644
--- a/chrome/browser/content_settings/permission_context_uma_util.h
+++ b/chrome/browser/content_settings/permission_context_uma_util.h
@@ -6,22 +6,28 @@
#define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_
#include "base/logging.h"
+#include "components/content_settings/core/common/content_settings.h"
mlamouri (slow - plz ping) 2015/06/30 10:27:20 nit: why do you need this include?
keenanb 2015/06/30 21:20:08 that's a vestige. removed.
#include "components/content_settings/core/common/content_settings_types.h"
class GURL;
+class HostContentSettingsMap;
+
// Provides a convenient way of logging UMA for permission related
// operations.
class PermissionContextUmaUtil {
public:
+ static void PermissionRequested(
+ ContentSettingsType permission,
+ const GURL& requesting_origin,
+ const GURL& embedding_origin,
+ HostContentSettingsMap* host_content_settings_map);
static void PermissionGranted(ContentSettingsType permission,
const GURL& requesting_origin);
static void PermissionDenied(ContentSettingsType permission,
const GURL& requesting_origin);
static void PermissionDismissed(ContentSettingsType permission,
const GURL& requesting_origin);
- static void PermissionRequested(ContentSettingsType permission,
- const GURL& requesting_origin);
static void PermissionIgnored(ContentSettingsType permission,
const GURL& requesting_origin);

Powered by Google App Engine
This is Rietveld 408576698