Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made suggested fixes and changed logging details. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 36452aa5c26c270e116b87468e7b6d6c86212d23..75136058ef5f58b9fbccd4fe8d96696c41775c0c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3912,6 +3912,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Number of times a given permission was requested.</summary>
</histogram>
+<histogram name="ContentSettings.PermissionRequested.OffOrigin"
mlamouri (slow - plz ping) 2015/06/29 14:23:08 nit: s/OffOrigin/CrossOrigin/ ?
keenanb 2015/06/29 19:09:00 i actually agree with you, but "OffOrigin" is com
+ enum="ContentSetting">
+ <owner>keenanb@google.com</owner>
+ <owner>jww@chromium.org</owner>
+ <summary>
+ For a given permission type (geolocation, and so on. see the corresponding
+ histrogram suffixes), the number of off-origin iframes whose embedding
+ origin has that permission type already allowed, blocked, or neither.
mlamouri (slow - plz ping) 2015/06/29 14:23:07 The description is confusing. Especially the "alre
keenanb 2015/06/29 19:09:00 you are right; it is confusing. i changed it.
+ </summary>
+</histogram>
+
+<histogram name="ContentSettings.PermissionRequested.OnOrigin"
mlamouri (slow - plz ping) 2015/06/29 14:23:07 nit: s/OnOrigin/SameOrigin/ ?
keenanb 2015/06/29 19:09:00 Done.
+ enum="PermissionType">
+ <owner>keenanb@google.com</owner>
+ <owner>jww@chromium.org</owner>
+ <summary>
+ The number of on-origin permission requests of each permission type
+ (geolocation, and so on).
+ </summary>
+</histogram>
+
<histogram name="ContentSettings.PermissionRequested_InsecureOrigin"
enum="PermissionType">
<owner>miguelg@chromium.org</owner>
@@ -72502,7 +72523,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="PerformanceMonitor.HighCPU"/>
</histogram_suffixes>
-<histogram_suffixes name="PermissionActions">
+<histogram_suffixes name="PermissionTypes">
<suffix name="MidiSysEx" label="Midi SysEx permsision actions"/>
<suffix name="PushMessaging" label="Push messaging permission actions"/>
<suffix name="Notifications" label="Notification permission actions"/>
@@ -72511,6 +72532,8 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="ContentSettings.PermissionActions"/>
<affected-histogram name="ContentSettings.PermissionActionsInsecureOrigin"/>
<affected-histogram name="ContentSettings.PermissionActionsSecureOrigin"/>
+ <affected-histogram name="ContentSettings.PermissionRequested.OffOrigin"/>
+ &quot;
keenanb 2015/06/25 21:52:07 this &quot; symbol was inserted automatically by a
</histogram_suffixes>
<histogram_suffixes name="PNaClTranslatorTypes" separator=".">

Powered by Google App Engine
This is Rietveld 408576698