Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: content/child/permissions/permission_dispatcher.cc

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed documentation. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/permissions/permission_dispatcher.cc
diff --git a/content/child/permissions/permission_dispatcher.cc b/content/child/permissions/permission_dispatcher.cc
index eb5ac4538f0f9caf86adea7769ed9ab016e18e7b..1784133788b31be6499b807c769e208c8b0b1abb 100644
--- a/content/child/permissions/permission_dispatcher.cc
+++ b/content/child/permissions/permission_dispatcher.cc
@@ -48,6 +48,8 @@ PermissionStatus GetPermissionStatus(blink::WebPermissionStatus status) {
return PERMISSION_STATUS_DENIED;
}
+// PERMISSION_STATUS_NUM is only a boundary value and should never be passed
+// into this function for |status|.
blink::WebPermissionStatus GetWebPermissionStatus(PermissionStatus status) {
switch (status) {
case PERMISSION_STATUS_GRANTED:
@@ -56,9 +58,11 @@ blink::WebPermissionStatus GetWebPermissionStatus(PermissionStatus status) {
return blink::WebPermissionStatusDenied;
case PERMISSION_STATUS_ASK:
return blink::WebPermissionStatusPrompt;
+ case PERMISSION_STATUS_NUM:
+ NOTREACHED();
+ break;
}
- NOTREACHED();
return blink::WebPermissionStatusDenied;
}

Powered by Google App Engine
This is Rietveld 408576698