Index: tools/metrics/histograms/histograms.xml |
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
index 36452aa5c26c270e116b87468e7b6d6c86212d23..e209b56a9dcded014d1d0088eb6dcaffa0143ad9 100644 |
--- a/tools/metrics/histograms/histograms.xml |
+++ b/tools/metrics/histograms/histograms.xml |
@@ -3912,6 +3912,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
<summary>Number of times a given permission was requested.</summary> |
</histogram> |
+<histogram name="ContentSettings.PermissionRequested.OffOrigin" |
mlamouri (slow - plz ping)
2015/06/30 10:27:20
Could you rename this to "Permissions.Requested.Cr
keenanb
2015/06/30 21:20:08
done. consistency aside, that naming makes more se
|
+ enum="ContentSetting"> |
+ <owner>keenanb@google.com</owner> |
+ <owner>jww@chromium.org</owner> |
+ <summary> |
+ The embedder's permission setting (allowed, blocked, neither) at the time of |
+ an off-origin iframe permission request for a given permission type. See the |
+ corresponding histogram suffixes. |
+ </summary> |
+</histogram> |
+ |
+<histogram name="ContentSettings.PermissionRequested.SameOrigin" |
mlamouri (slow - plz ping)
2015/06/30 10:27:21
ditto: "Permissions.Requested.SameOrigin"
keenanb
2015/06/30 21:20:08
Done.
|
+ enum="PermissionType"> |
+ <owner>keenanb@google.com</owner> |
+ <owner>jww@chromium.org</owner> |
+ <summary> |
+ The permission type (geolocation, and such) of a same-origin permission |
+ request. |
+ </summary> |
+</histogram> |
+ |
<histogram name="ContentSettings.PermissionRequested_InsecureOrigin" |
enum="PermissionType"> |
<owner>miguelg@chromium.org</owner> |
@@ -72502,7 +72523,7 @@ To add a new entry, add it with any value and run test to compute valid value. |
<affected-histogram name="PerformanceMonitor.HighCPU"/> |
</histogram_suffixes> |
-<histogram_suffixes name="PermissionActions"> |
+<histogram_suffixes name="PermissionTypes"> |
mlamouri (slow - plz ping)
2015/06/30 10:27:20
That change is not correct, it would change the UM
keenanb
2015/06/30 21:20:08
i don't understand. can you double check to see wh
|
<suffix name="MidiSysEx" label="Midi SysEx permsision actions"/> |
<suffix name="PushMessaging" label="Push messaging permission actions"/> |
<suffix name="Notifications" label="Notification permission actions"/> |
@@ -72511,6 +72532,7 @@ To add a new entry, add it with any value and run test to compute valid value. |
<affected-histogram name="ContentSettings.PermissionActions"/> |
<affected-histogram name="ContentSettings.PermissionActionsInsecureOrigin"/> |
<affected-histogram name="ContentSettings.PermissionActionsSecureOrigin"/> |
+ <affected-histogram name="ContentSettings.PermissionRequested.OffOrigin"/> |
</histogram_suffixes> |
<histogram_suffixes name="PNaClTranslatorTypes" separator="."> |