Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: chrome/browser/permissions/permission_context_uma_util.cc

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just rebased. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_context_uma_util.h"
6
5 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
6 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
7 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/permissions/permission_context_uma_util.h" 10 #include "chrome/browser/permissions/permission_manager.h"
11 #include "chrome/browser/profiles/profile.h"
9 #include "components/rappor/rappor_utils.h" 12 #include "components/rappor/rappor_utils.h"
10 #include "content/public/browser/permission_type.h" 13 #include "content/public/browser/permission_type.h"
11 #include "content/public/common/origin_util.h" 14 #include "content/public/common/origin_util.h"
12 #include "url/gurl.h" 15 #include "url/gurl.h"
13 16
14 // UMA keys need to be statically initialized so plain function would not 17 // UMA keys need to be statically initialized so plain function would not
15 // work. Use a Macro instead. 18 // work. Use a Macro instead.
16 #define PERMISSION_ACTION_UMA(secure_origin, permission, permission_secure, \ 19 #define PERMISSION_ACTION_UMA(secure_origin, permission, permission_secure, \
17 permission_insecure, action) \ 20 permission_insecure, action) \
18 UMA_HISTOGRAM_ENUMERATION(permission, action, PERMISSION_ACTION_NUM); \ 21 UMA_HISTOGRAM_ENUMERATION(permission, action, PERMISSION_ACTION_NUM); \
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 NOTREACHED() << "PERMISSION " << permission << " not accounted for"; 135 NOTREACHED() << "PERMISSION " << permission << " not accounted for";
133 } 136 }
134 137
135 const std::string& rappor_metric = GetRapporMetric(permission, action); 138 const std::string& rappor_metric = GetRapporMetric(permission, action);
136 if (!rappor_metric.empty()) 139 if (!rappor_metric.empty())
137 rappor::SampleDomainAndRegistryFromGURL( 140 rappor::SampleDomainAndRegistryFromGURL(
138 g_browser_process->rappor_service(), rappor_metric, 141 g_browser_process->rappor_service(), rappor_metric,
139 requesting_origin); 142 requesting_origin);
140 } 143 }
141 144
145 std::string PermissionTypeToString(PermissionType permission_type) {
146 switch (permission_type) {
147 case PermissionType::MIDI_SYSEX:
148 return "MidiSysex";
149 case PermissionType::PUSH_MESSAGING:
150 return "PushMessaging";
151 case PermissionType::NOTIFICATIONS:
152 return "Notifications";
153 case PermissionType::GEOLOCATION:
154 return "Geolocation";
155 case PermissionType::PROTECTED_MEDIA_IDENTIFIER:
156 return "ProtectedMediaIdentifier";
157 case PermissionType::NUM:
158 break;
159 }
160 NOTREACHED();
161 return std::string();
162 }
163
142 void RecordPermissionRequest(ContentSettingsType permission, 164 void RecordPermissionRequest(ContentSettingsType permission,
143 const GURL& requesting_origin) { 165 const GURL& requesting_origin,
166 const GURL& embedding_origin,
167 Profile* profile) {
144 bool secure_origin = content::IsOriginSecure(requesting_origin); 168 bool secure_origin = content::IsOriginSecure(requesting_origin);
145 PermissionType type; 169 PermissionType type;
146 switch (permission) { 170 switch (permission) {
147 case CONTENT_SETTINGS_TYPE_GEOLOCATION: 171 case CONTENT_SETTINGS_TYPE_GEOLOCATION:
148 type = PermissionType::GEOLOCATION; 172 type = PermissionType::GEOLOCATION;
149 rappor::SampleDomainAndRegistryFromGURL( 173 rappor::SampleDomainAndRegistryFromGURL(
150 g_browser_process->rappor_service(), 174 g_browser_process->rappor_service(),
151 "ContentSettings.PermissionRequested.Geolocation.Url", 175 "ContentSettings.PermissionRequested.Geolocation.Url",
152 requesting_origin); 176 requesting_origin);
153 break; 177 break;
(...skipping 27 matching lines...) Expand all
181 UMA_HISTOGRAM_ENUMERATION( 205 UMA_HISTOGRAM_ENUMERATION(
182 "ContentSettings.PermissionRequested_SecureOrigin", 206 "ContentSettings.PermissionRequested_SecureOrigin",
183 static_cast<base::HistogramBase::Sample>(type), 207 static_cast<base::HistogramBase::Sample>(type),
184 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 208 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
185 } else { 209 } else {
186 UMA_HISTOGRAM_ENUMERATION( 210 UMA_HISTOGRAM_ENUMERATION(
187 "ContentSettings.PermissionRequested_InsecureOrigin", 211 "ContentSettings.PermissionRequested_InsecureOrigin",
188 static_cast<base::HistogramBase::Sample>(type), 212 static_cast<base::HistogramBase::Sample>(type),
189 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 213 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
190 } 214 }
215
216 // In order to gauge the compatibility risk of implementing an improved
217 // iframe permissions security model, we would like to know the ratio of
218 // same-origin to cross-origin permission requests. Our estimate of this
219 // ratio could be somewhat biased by repeated requests coming from a
220 // single frame, but we expect this to be insignificant.
221 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) {
222 content::PermissionManager* manager = profile->GetPermissionManager();
223 if (!manager)
224 return;
225 content::PermissionStatus embedding_permission_status =
226 manager->GetPermissionStatus(type, embedding_origin, embedding_origin);
227
228 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
229 "Permissions.Requested.CrossOrigin_" + PermissionTypeToString(type), 1,
230 content::PERMISSION_STATUS_LAST, content::PERMISSION_STATUS_LAST + 1,
231 base::HistogramBase::kUmaTargetedHistogramFlag);
232 histogram->Add(embedding_permission_status);
233 } else {
234 UMA_HISTOGRAM_ENUMERATION(
235 "Permissions.Requested.SameOrigin",
236 static_cast<base::HistogramBase::Sample>(type),
237 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
238 }
191 } 239 }
192 240
193 } // namespace 241 } // namespace
194 242
195 // Make sure you update histograms.xml permission histogram_suffix if you 243 // Make sure you update histograms.xml permission histogram_suffix if you
196 // add new permission 244 // add new permission
197 void PermissionContextUmaUtil::PermissionRequested( 245 void PermissionContextUmaUtil::PermissionRequested(
198 ContentSettingsType permission, const GURL& requesting_origin) { 246 ContentSettingsType permission,
199 RecordPermissionRequest(permission, requesting_origin); 247 const GURL& requesting_origin,
248 const GURL& embedding_origin,
249 Profile* profile) {
250 RecordPermissionRequest(permission, requesting_origin, embedding_origin,
251 profile);
200 } 252 }
201 253
202 void PermissionContextUmaUtil::PermissionGranted( 254 void PermissionContextUmaUtil::PermissionGranted(
203 ContentSettingsType permission, const GURL& requesting_origin) { 255 ContentSettingsType permission, const GURL& requesting_origin) {
204 RecordPermissionAction(permission, GRANTED, requesting_origin); 256 RecordPermissionAction(permission, GRANTED, requesting_origin);
205 } 257 }
206 258
207 void PermissionContextUmaUtil::PermissionDenied( 259 void PermissionContextUmaUtil::PermissionDenied(
208 ContentSettingsType permission, const GURL& requesting_origin) { 260 ContentSettingsType permission, const GURL& requesting_origin) {
209 RecordPermissionAction(permission, DENIED, requesting_origin); 261 RecordPermissionAction(permission, DENIED, requesting_origin);
210 } 262 }
211 263
212 void PermissionContextUmaUtil::PermissionDismissed( 264 void PermissionContextUmaUtil::PermissionDismissed(
213 ContentSettingsType permission, const GURL& requesting_origin) { 265 ContentSettingsType permission, const GURL& requesting_origin) {
214 RecordPermissionAction(permission, DISMISSED, requesting_origin); 266 RecordPermissionAction(permission, DISMISSED, requesting_origin);
215 } 267 }
216 268
217 void PermissionContextUmaUtil::PermissionIgnored( 269 void PermissionContextUmaUtil::PermissionIgnored(
218 ContentSettingsType permission, const GURL& requesting_origin) { 270 ContentSettingsType permission, const GURL& requesting_origin) {
219 RecordPermissionAction(permission, IGNORED, requesting_origin); 271 RecordPermissionAction(permission, IGNORED, requesting_origin);
220 } 272 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/permission_context_uma_util.h ('k') | content/public/common/permission_status.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698