content/public/common/permission_status.mojom - Issue 1197853005: Collecting statistics on iframe permissions use.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/common/permission_status.mojom

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed NOTREACHED calls. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/child/permissions/permission_dispatcher.cc ('K') | « content/child/permissions/permission_dispatcher.cc ('k') | content/renderer/notification_permission_dispatcher.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module content;	5 module content;

6	6

7 enum PermissionStatus {	7 enum PermissionStatus {

8 GRANTED,	8 GRANTED,

9 DENIED,	9 DENIED,

10 ASK	10 ASK,

	11 NUM
	mlamouri (slow - plz ping) 2015/07/07 21:18:47 I'm confused but maybe I'm missing something. Why I'm confused but maybe I'm missing something. Why are you adding this here? keenanb 2015/07/08 00:37:21 UMA_HISTOGRAM_ENUMERATION needs a boundary value. Show quoted text On 2015/07/07 21:18:47, Mounir Lamouri wrote: > I'm confused but maybe I'm missing something. Why are you adding this here? UMA_HISTOGRAM_ENUMERATION needs a boundary value. correct me if there's a better way. mlamouri (slow - plz ping) 2015/07/08 15:00:44 Can you do: LAST = ASK, instead of NUM. Then, yo Show quoted text On 2015/07/08 at 00:37:21, keenanb wrote: > On 2015/07/07 21:18:47, Mounir Lamouri wrote: > > I'm confused but maybe I'm missing something. Why are you adding this here? > > UMA_HISTOGRAM_ENUMERATION needs a boundary value. correct me if there's a better way. Can you do: LAST = ASK, instead of NUM. Then, you could pass LAST + 1. I think it will prevent the new entry in switch statements.
11 };	12 };

OLD	NEW