Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed to use permission status. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 45cc91f35052ca012e8f8b908028caeef06f442d..89c023bccf8408a67a67d1f6dc0fcd532ab000dd 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -28144,6 +28144,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Permissions.Requested.CrossOrigin" enum="PermissionStatus">
+ <owner>keenanb@google.com</owner>
+ <owner>jww@chromium.org</owner>
+ <summary>
+ The embedder's permission setting at the time of a cross-origin iframe
+ permission request for a given permission type. See the corresponding
+ histogram suffixes.
+ </summary>
+</histogram>
+
+<histogram name="Permissions.Requested.SameOrigin" enum="PermissionType">
+ <owner>keenanb@google.com</owner>
+ <owner>jww@chromium.org</owner>
+ <summary>
+ The permission type (geolocation, and such) of a same-origin permission
+ request.
+ </summary>
+</histogram>
+
<histogram name="Platform.AsvGroup">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
@@ -63760,6 +63779,12 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="3" label="IGNORED"/>
</enum>
+<enum name="PermissionStatus" type="int">
jww 2015/07/07 18:41:46 Shouldn't this be far below in the <enums> section
keenanb 2015/07/07 21:02:59 i was confused for a second and double checked, bu
+ <int value="0" label="PERMISSION_STATUS_GRANTED"/>
+ <int value="1" label="PERMISSION_STATUS_DENIED"/>
+ <int value="2" label="PERMISSION_STATUS_ASK"/>
+</enum>
+
<enum name="PermissionType" type="int">
<int value="0" label="PERMISSION_UNKONWN"/>
<int value="1" label="PERMISSION_MIDI_SYSEX"/>
@@ -73001,7 +73026,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="PerformanceMonitor.HighCPU"/>
</histogram_suffixes>
-<histogram_suffixes name="PermissionActions">
+<histogram_suffixes name="PermissionTypes">
<suffix name="MidiSysEx" label="Midi SysEx permsision actions"/>
<suffix name="PushMessaging" label="Push messaging permission actions"/>
<suffix name="Notifications" label="Notification permission actions"/>
@@ -73010,6 +73035,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="ContentSettings.PermissionActions"/>
<affected-histogram name="ContentSettings.PermissionActionsInsecureOrigin"/>
<affected-histogram name="ContentSettings.PermissionActionsSecureOrigin"/>
+ <affected-histogram name="Permissions.Requested.CrossOrigin"/>
</histogram_suffixes>
<histogram_suffixes name="PNaClTranslatorTypes" separator=".">

Powered by Google App Engine
This is Rietveld 408576698