Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: remoting/protocol/p2p_datagram_socket.h

Issue 1197853003: Add P2PDatagramSocket and P2PStreamSocket interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/p2p_datagram_socket.h
diff --git a/remoting/protocol/p2p_datagram_socket.h b/remoting/protocol/p2p_datagram_socket.h
new file mode 100644
index 0000000000000000000000000000000000000000..137c224888708854c44518591551d12c3d05f89a
--- /dev/null
+++ b/remoting/protocol/p2p_datagram_socket.h
@@ -0,0 +1,49 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_PROTOCOL_P2P_DATAGRAM_SOCKET_H_
+#define REMOTING_PROTOCOL_P2P_DATAGRAM_SOCKET_H_
+
+#include "net/base/completion_callback.h"
+
+namespace net {
+class IOBuffer;
+} // namespace net
+
+namespace remoting {
+namespace protocol {
+
+// Peer-to-peer socket with datagram semantics.
+class P2PDatagramSocket {
+ public:
+ virtual ~P2PDatagramSocket() {};
+
+ // Receives a packet, up to |buf_len| bytes, from the socket. The number of
+ // bytes read is returned, or an error is returned upon failure.
+ // ERR_IO_PENDING is returned if the operation could not be completed
+ // synchronously, in which case the result will be passed to the callback when
+ // available. If the operation is not completed immediately, the socket
+ // acquires a reference to the provided buffer until the callback is invoked
+ // or the socket is closed. If the socket is destroyed before the read
+ // completes, the callback will not be invoked.
+ virtual int Recv(const scoped_refptr<net::IOBuffer>& buf, int buf_len,
+ const net::CompletionCallback& callback) = 0;
+
+ // Sends a packet. Size of the incoming packet is returned in case of success.
Wez 2015/07/14 18:28:09 nit: This is send; the packet is outgoing, not inc
Sergey Ulanov 2015/07/14 21:07:54 Done.
+ // If the packet is larger than |buf_len| then it's truncated, i.e. only the
Wez 2015/07/14 18:28:09 nit: it's -> it is
Sergey Ulanov 2015/07/14 21:07:54 Done.
+ // first |buf_len| bytes are stored in the buffer. In case of a failure an
Wez 2015/07/14 18:28:09 nit: "In case of failure a net error code is retur
Wez 2015/07/14 18:28:09 You mean that only |buf_len| bytes are written?
Sergey Ulanov 2015/07/14 21:07:54 Done.
Sergey Ulanov 2015/07/14 21:07:54 Done.
+ // error is returned. ERR_IO_PENDING is returned if the operation could not be
+ // completed synchronously, in which case the result will be passed to the
+ // callback when available. If the operation is not completed immediately, the
+ // socket acquires a reference to the provided buffer until the callback is
+ // invoked or the socket is closed. Implementations of this method should not
+ // modify the contents of the actual buffer that is written to the socket.
+ virtual int Send(const scoped_refptr<net::IOBuffer>& buf, int buf_len,
+ const net::CompletionCallback& callback) = 0;
+};
+
+} // namespace protocol
+} // namespace remoting
+
+#endif // REMOTING_PROTOCOL_P2P_DATAGRAM_SOCKET_H_

Powered by Google App Engine
This is Rietveld 408576698