Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: remoting/base/buffered_socket_writer_unittest.cc

Issue 1197853003: Add P2PDatagramSocket and P2PStreamSocket interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/base/buffered_socket_writer.cc ('k') | remoting/client/key_event_mapper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/buffered_socket_writer_unittest.cc
diff --git a/remoting/base/buffered_socket_writer_unittest.cc b/remoting/base/buffered_socket_writer_unittest.cc
index 07bb2ece17d6b290005da58b79aadc6a83d07f79..8e5a1a5b7fbd1adfd2359c33328a7445b3e8e9fd 100644
--- a/remoting/base/buffered_socket_writer_unittest.cc
+++ b/remoting/base/buffered_socket_writer_unittest.cc
@@ -18,7 +18,8 @@
namespace remoting {
namespace {
-const int kTestBufferSize = 10 * 1024; // 10k;
+
+const int kTestBufferSize = 10000;
const size_t kWriteChunkSize = 1024U;
class SocketDataProvider: public net::SocketDataProvider {
@@ -93,9 +94,9 @@ class BufferedSocketWriterTest : public testing::Test {
net::MockConnect(net::SYNCHRONOUS, net::OK));
EXPECT_EQ(net::OK, socket_->Connect(net::CompletionCallback()));
- writer_.reset(new BufferedSocketWriter());
- writer_->Init(socket_.get(), base::Bind(
- &BufferedSocketWriterTest::OnWriteFailed, base::Unretained(this)));
+ writer_ = BufferedSocketWriter::CreateForSocket(
+ socket_.get(), base::Bind(&BufferedSocketWriterTest::OnWriteFailed,
+ base::Unretained(this)));
test_buffer_ = new net::IOBufferWithSize(kTestBufferSize);
test_buffer_2_ = new net::IOBufferWithSize(kTestBufferSize);
for (int i = 0; i< kTestBufferSize; ++i) {
@@ -126,7 +127,7 @@ class BufferedSocketWriterTest : public testing::Test {
void TestAppendInCallback() {
writer_->Write(test_buffer_, base::Bind(
- base::IgnoreResult(&BufferedSocketWriterBase::Write),
+ base::IgnoreResult(&BufferedSocketWriter::Write),
base::Unretained(writer_.get()), test_buffer_2_,
base::Closure()));
base::RunLoop().RunUntilIdle();
« no previous file with comments | « remoting/base/buffered_socket_writer.cc ('k') | remoting/client/key_event_mapper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698