Allocate a drawing recorder locally to BoxPainter code in the mask phase.

Allocate a drawing recorder locally to BoxPainter code in the mask phase.

Previously, call sites were expected to allocate one. This is a buggy pattern,
since some might forget. In particular, PartPainter did forget, causing the
referenced crash.

BUG=500426, 501485
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197518

[chrishtr, 2015-06-19 22:46:59]

chrishtr@chromium.org changed reviewers:
+ schenney@chromium.org, wkorman@chromium.org

[chrishtr, 2015-06-19 23:01:27]

Also added a test with iframes, to address:

https://code.google.com/p/chromium/issues/detail?id=501485#c16
https://code.google.com/p/chromium/issues/detail?id=501485#c2

[wkorman, 2015-06-19 23:20:43]

lgtm

https://codereview.chromium.org/1197843004/diff/60001/Source/core/paint/BoxPa...
File Source/core/paint/BoxPainter.cpp (right):

https://codereview.chromium.org/1197843004/diff/60001/Source/core/paint/BoxPa...
Source/core/paint/BoxPainter.cpp:526: if (recorder.canUseCachedDrawing())
Could also just add this to the three bail-out conditionals we've already got on
line 528 but perhaps having separate is clearer, fine either way.

[chrishtr, 2015-06-19 23:23:45]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-19 23:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197843004/60001

[commit-bot: I haz the power, 2015-06-20 00:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-20 00:55:19]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59890)

[chrishtr, 2015-06-20 01:06:26]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-20 01:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197843004/60001

[commit-bot: I haz the power, 2015-06-20 01:44:03]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197518

[chrishtr, 2015-06-20 02:22:45]

https://codereview.chromium.org/1197843004/diff/60001/Source/core/paint/BoxPa...
File Source/core/paint/BoxPainter.cpp (right):

https://codereview.chromium.org/1197843004/diff/60001/Source/core/paint/BoxPa...
Source/core/paint/BoxPainter.cpp:526: if (recorder.canUseCachedDrawing())
On 2015/06/19 at 23:20:43, wkorman wrote:
> Could also just add this to the three bail-out conditionals we've already got
on line 528 but perhaps having separate is clearer, fine either way.

I prefer separate, to make it clear we are checking for caching.