Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1197793002: Fix some build symbol configuration. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some build symbol configuration. Remove -gdwarf-4 from GYP build. This is the default for GCC 4.8 which is now required, so this command-line argument is redundant. Only set use_debug_fission in the GN build in debug mode. This matches GYP. Release mode symbols will be non-fission. Implement linux_symbols target in GN. Convert dump_app_syms from sh to Python for better GN usability, and it's more readable for normal programmers on the team. Reland of https://codereview.chromium.org/1182663007/ Reland of https://codereview.chromium.org/1179393004/ TBR=thakis@chromium.org Committed: https://crrev.com/2f27f9bf85b21f149c5972197ef07f957fe20b41 Cr-Commit-Position: refs/heads/master@{#335370}

Patch Set 1 : Original patch #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -41 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D build/linux/dump_app_syms View 1 chunk +0 lines, -36 lines 0 comments Download
A build/linux/dump_app_syms.py View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197793002/20001
5 years, 6 months ago (2015-06-19 17:19:11 UTC) #2
brettw
I'm guessing the problem is a path issue.
5 years, 6 months ago (2015-06-19 17:21:56 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/35897)
5 years, 6 months ago (2015-06-19 19:34:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197793002/20001
5 years, 6 months ago (2015-06-19 21:06:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 22:35:14 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 22:37:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f27f9bf85b21f149c5972197ef07f957fe20b41
Cr-Commit-Position: refs/heads/master@{#335370}

Powered by Google App Engine
This is Rietveld 408576698