Source/core/html/shadow/MediaControls.cpp - Issue 1197773002: Always show "exit fullscreen" button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 1197773002: Always show "exit fullscreen" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: updated test expectations Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/MediaControls.cpp

diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp

index 43d22a4cf8f2bc617013e90ffb0185038d8b74aa..888d76060961af0ccde7976e9b4514ed72563ebf 100644

--- a/Source/core/html/shadow/MediaControls.cpp

+++ b/Source/core/html/shadow/MediaControls.cpp

@@ -184,7 +184,8 @@ void MediaControls::reset()

refreshClosedCaptionsButtonVisibility();

- if (mediaElement().hasVideo() && fullscreenIsSupported(document()))

+ if ((mediaElement().hasVideo() && fullscreenIsSupported(document()))

+ || mediaElement().isFullscreen())

xhwang 2015/06/23 20:22:01 Maybe add some comment here. Otherwise it makes pe

eae 2015/06/23 20:30:45 Seconded.

liberato (no reviews please) 2015/06/23 20:37:41 third-ed. i had additional logic that i removed,

m_fullScreenButton->show();

else

m_fullScreenButton->hide();