Always show "exit fullscreen" button.

Always show "exit fullscreen" button.

When switching to full screen mode, we may choose to hide the exit
fullscreen button, based on whether we believe the media is capable
of being shown fullscreen.  On android, this behavior can cause us
to believe that entering fullscreen is okay, only to decide that it
isn't when the user actually enters fullscreen.  This leaves the
fullscreen button hidden in fullscreen mode, with no way back.

This is caused by a lack of support in Android's MediaPlayer for
checking the type of streams available before playback starts.  It
goes by mime type only, and defaults to "yes" if that's unavailable.
Until we move the media stack away from android's MediaPlayer, it
will be hard to fix this root cause.

This CL makes the fullscreen button show up unconditionally when the
media is in fullscreen.  Either way, this seems like a good idea.

BUG=500732
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197678

[liberato (no reviews please), 2015-06-23 19:59:56]

liberato@chromium.org changed reviewers:
+ eae@chromium.org, xhwang@chromium.org, yiningc@chromium.org

[liberato (no reviews please), 2015-06-23 20:06:36]

small patch to avoid locking users into full-screen mode, mostly for android.

win and mac tests are failing on other CLs
(https://codereview.chromium.org/1207463002/ for example).

Feedback is appreciated.

thanks
-fl

[xhwang, 2015-06-23 20:22:01]

looking good. I'll defer to eae@ to finish the review.

https://codereview.chromium.org/1197773002/diff/20001/Source/core/html/shadow...
File Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/1197773002/diff/20001/Source/core/html/shadow...
Source/core/html/shadow/MediaControls.cpp:188: || mediaElement().isFullscreen())
Maybe add some comment here. Otherwise it makes people wonder how we get into
the fullscreen mode in the first place.

[eae, 2015-06-23 20:30:45]

LGTM but please add a comment before landing.

https://codereview.chromium.org/1197773002/diff/20001/Source/core/html/shadow...
File Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/1197773002/diff/20001/Source/core/html/shadow...
Source/core/html/shadow/MediaControls.cpp:188: || mediaElement().isFullscreen())
On 2015/06/23 20:22:01, xhwang wrote:
> Maybe add some comment here. Otherwise it makes people wonder how we get into
> the fullscreen mode in the first place.

Seconded.

[liberato (no reviews please), 2015-06-23 20:37:41]

https://codereview.chromium.org/1197773002/diff/20001/Source/core/html/shadow...
File Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/1197773002/diff/20001/Source/core/html/shadow...
Source/core/html/shadow/MediaControls.cpp:188: || mediaElement().isFullscreen())
On 2015/06/23 20:30:45, eae wrote:
> On 2015/06/23 20:22:01, xhwang wrote:
> > Maybe add some comment here. Otherwise it makes people wonder how we get
into
> > the fullscreen mode in the first place.
> 
> Seconded.

third-ed.  i had additional logic that i removed, and deleted the comment along
with it.  oops.

[liberato (no reviews please), 2015-06-23 20:38:26]

The CQ bit was checked by liberato@chromium.org

[liberato (no reviews please), 2015-06-23 20:38:27]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1197773002/#ps40001
(title: "/* expositionary text */")

[commit-bot: I haz the power, 2015-06-23 20:38:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197773002/40001

[commit-bot: I haz the power, 2015-06-23 20:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 20:42:53]

Exceeded global retry quota

[liberato (no reviews please), 2015-06-23 21:43:24]

The CQ bit was checked by liberato@chromium.org

[commit-bot: I haz the power, 2015-06-23 21:44:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197773002/40001

[commit-bot: I haz the power, 2015-06-23 22:50:59]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197678