Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1197763002: Oilpan: keep StashedPortCollection always on the heap. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: keep StashedPortCollection always on the heap. Have StashedPortCollection derive from RefCountedGarbageCollected, allowing this EventTarget to reside on the heap irrespective of ENABLE(OILPAN). R=haraken BUG=497595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/StashedPortCollection.h View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/modules/serviceworkers/StashedPortCollection.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/StashedPortCollection.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. time to ship some of these; ought not be blocked on ...
5 years, 6 months ago (2015-06-19 18:19:17 UTC) #2
haraken
On 2015/06/19 18:19:17, sof wrote: > please take a look. > > time to ship ...
5 years, 6 months ago (2015-06-19 23:55:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197763002/1
5 years, 6 months ago (2015-06-20 05:42:43 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-20 06:35:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197529

Powered by Google App Engine
This is Rietveld 408576698