Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(191)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1197733009: Prepare LayoutTests for lazy loading testRunner and internals. (Closed)

Created:
4 years, 10 months ago by esprehn
Modified:
4 years, 10 months ago
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, nhiroki, scheib+watch_chromium.org, serviceworker-reviews, timvolodine, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Prepare LayoutTests for lazy loading testRunner and internals. 1) Don't check hasOwnProperty for internals or testRunner. 2) You can no longer get internals/testRunner out of a detached frame. BUG=501648 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M LayoutTests/bluetooth/connectGATT.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/bluetooth/getCharacteristic.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/bluetooth/getPrimaryService.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/bluetooth/idl-BluetoothDevice.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/bluetooth/readValue.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/bluetooth/requestDevice.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-height-extend-to-zoom.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-min-width-extend-to-zoom.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-width-extend-to-zoom.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Geolocation/invalid-internals-arguments-no-crash-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/Geolocation/script-tests/invalid-internals-arguments.js View 1 chunk +8 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/geofencing/event_triggering.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/stashed-ports-after-terminate.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/printing/page-rule-specificity.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197733009/1
4 years, 10 months ago (2015-06-23 02:51:40 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-23 04:29:45 UTC) #4
esprehn
4 years, 10 months ago (2015-06-23 11:28:17 UTC) #6
esprehn
4 years, 10 months ago (2015-06-23 11:28:38 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2015-06-23 14:58:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197733009/1
4 years, 10 months ago (2015-06-23 15:34:01 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 15:38:03 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197657

Powered by Google App Engine
This is Rietveld 408576698