Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1197733002: Screen attribute availWidth/availHeight/width/height type changed to long (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Screen attribute availWidth/availHeight/width/height type changed to long There aren't any internal callers of these APIs and the changes are to remove casts. BUG=496400 R=philipj Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M Source/core/frame/Screen.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/frame/Screen.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/frame/Screen.idl View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197733002/1
5 years, 6 months ago (2015-06-19 14:15:30 UTC) #2
Habib Virji
Please take a look.
5 years, 6 months ago (2015-06-19 15:46:52 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-19 16:37:15 UTC) #5
Rick Byers
LGTM, thanks! Looks like there aren't any internal callers of these APIs to fix and ...
5 years, 6 months ago (2015-06-23 00:31:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197733002/1
5 years, 6 months ago (2015-06-23 07:19:24 UTC) #9
Habib Virji
Thanks Rick, used your line in CL description.
5 years, 6 months ago (2015-06-23 08:07:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197637
5 years, 6 months ago (2015-06-23 09:31:00 UTC) #11
philipj_slow
5 years, 6 months ago (2015-06-23 10:46:34 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698