Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 1197723003: Fix aria-owns support in ARIA grids. (Closed)

Created:
4 years, 10 months ago by dmazzoni
Modified:
4 years, 10 months ago
Reviewers:
Mike West
CC:
aboxhall, blink-reviews, dmazzoni, je_julie, nektarios
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix aria-owns support in ARIA grids. AXARIAGrid overrides addChildren so it didn't get the new behavior I added in AXLayoutObject by default. BUG=489590 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197683

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Fix style nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
A LayoutTests/accessibility/aria-owns-grid.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXARIAGrid.cpp View 1 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
dmazzoni
4 years, 10 months ago (2015-06-23 05:34:23 UTC) #2
Mike West
LGTM. https://codereview.chromium.org/1197723003/diff/20001/LayoutTests/accessibility/aria-owns-grid.html File LayoutTests/accessibility/aria-owns-grid.html (right): https://codereview.chromium.org/1197723003/diff/20001/LayoutTests/accessibility/aria-owns-grid.html#newcode25 LayoutTests/accessibility/aria-owns-grid.html:25: { Tiny Style Nit: Put this on line ...
4 years, 10 months ago (2015-06-23 09:21:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197723003/40001
4 years, 10 months ago (2015-06-23 16:51:32 UTC) #6
dmazzoni
https://codereview.chromium.org/1197723003/diff/20001/LayoutTests/accessibility/aria-owns-grid.html File LayoutTests/accessibility/aria-owns-grid.html (right): https://codereview.chromium.org/1197723003/diff/20001/LayoutTests/accessibility/aria-owns-grid.html#newcode25 LayoutTests/accessibility/aria-owns-grid.html:25: { On 2015/06/23 09:21:26, Mike West wrote: > Tiny ...
4 years, 10 months ago (2015-06-23 16:52:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60347)
4 years, 10 months ago (2015-06-23 18:35:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197723003/40001
4 years, 10 months ago (2015-06-23 20:04:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60402)
4 years, 10 months ago (2015-06-23 22:34:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197723003/40001
4 years, 10 months ago (2015-06-23 23:30:36 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 23:34:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197683

Powered by Google App Engine
This is Rietveld 408576698