Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1197703004: [android] Add toolchain path logic to gyp config. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[android] Add toolchain path logic to gyp config. BUG=chromium:502176 LOG=n NOTRY=true Committed: https://crrev.com/5fe960a966082e848427d25e03b57f92efe59bba Cr-Commit-Position: refs/heads/master@{#29183}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M build/android.gypi View 1 2 1 chunk +32 lines, -2 lines 0 comments Download
M build/standalone.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197703004/20001
5 years, 6 months ago (2015-06-22 10:22:53 UTC) #3
Michael Achenbach
PTAL. I'll remove the other side of the path logic from Makefile.android in an extra ...
5 years, 6 months ago (2015-06-22 10:23:45 UTC) #4
ulan
lgtm https://codereview.chromium.org/1197703004/diff/20001/build/android.gypi File build/android.gypi (right): https://codereview.chromium.org/1197703004/diff/20001/build/android.gypi#newcode47 build/android.gypi:47: # Android API level 16 is JB (Android ...
5 years, 6 months ago (2015-06-22 10:41:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-22 10:45:40 UTC) #7
Michael Achenbach
https://codereview.chromium.org/1197703004/diff/20001/build/android.gypi File build/android.gypi (right): https://codereview.chromium.org/1197703004/diff/20001/build/android.gypi#newcode47 build/android.gypi:47: # Android API level 16 is JB (Android 4.1) ...
5 years, 6 months ago (2015-06-22 11:29:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197703004/40001
5 years, 6 months ago (2015-06-22 11:30:12 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-22 11:32:08 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 11:32:26 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5fe960a966082e848427d25e03b57f92efe59bba
Cr-Commit-Position: refs/heads/master@{#29183}

Powered by Google App Engine
This is Rietveld 408576698