Use big-boy Types to annotate interface descriptor parameters

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_H_
 #define V8_COMPILER_H_
 
 #include "src/allocation.h"
 #include "src/ast.h"
 #include "src/bailout-reason.h"
 #include "src/compilation-dependencies.h"
+#include "src/signature.h"
 #include "src/zone.h"
 
 namespace v8 {
 namespace internal {
 
 class AstValueFactory;
 class HydrogenCodeStub;
 class ParseInfo;
 class ScriptData;
 
@@ skipping 259 matching lines @@
   bool IsOptimizable() const { return mode_ == BASE; }
   bool IsStub() const { return mode_ == STUB; }
   void SetOptimizing(BailoutId osr_ast_id, Handle<Code> unoptimized) {
     DCHECK(!shared_info().is_null());
     SetMode(OPTIMIZE);
     osr_ast_id_ = osr_ast_id;
     unoptimized_code_ = unoptimized;
     optimization_id_ = isolate()->NextOptimizationId();
   }
 
+  void SetFunctionType(Type::FunctionType* function_type) {

[Benedikt Meurer, 2015/06/22 05:27:28]

Nit: I think Type::FunctionType is an implementation detail of the type system
and should not be exposed? Use Type* instead.

[danno, 2015/06/23 14:39:44]

As discussed over chat with you and Jaro, I'm going to leave this as-is for now.

[rossberg, 2015/06/29 12:29:34]

FunctionType is not an implementation detail -- it is the public interface class
to get to a function type's attributes. Similarly for the other structural
types. The only internal classes are BitsetType, StructuralType, and UnionType
(see the respective comments at the beginning of TypeImpl).

+    function_type_ = function_type;
+  }
+  Type::FunctionType* function_type() const { return function_type_; }
+
   void SetStub(CodeStub* code_stub) {
     SetMode(STUB);
     code_stub_ = code_stub;
   }
 
   // Deoptimization support.
   bool HasDeoptimizationSupport() const {
     return GetFlag(kDeoptimizationSupport);
   }
   void EnableDeoptimizationSupport() {
@@ skipping 171 matching lines @@
   // during graph optimization.
   int opt_count_;
 
   // Number of parameters used for compilation of stubs that require arguments.
   int parameter_count_;
 
   int optimization_id_;
 
   int osr_expr_stack_height_;
 
+  Type::FunctionType* function_type_;

[Benedikt Meurer, 2015/06/22 05:27:28]

See above.

+
   DISALLOW_COPY_AND_ASSIGN(CompilationInfo);
 };
 
 
 // A wrapper around a CompilationInfo that detaches the Handles from
 // the underlying DeferredHandleScope and stores them in info_ on
 // destruction.
 class CompilationHandleScope BASE_EMBEDDED {
  public:
   explicit CompilationHandleScope(CompilationInfo* info)
@@ skipping 190 matching lines @@
   Zone zone_;
   size_t info_zone_start_allocation_size_;
   base::ElapsedTimer timer_;
 
   DISALLOW_COPY_AND_ASSIGN(CompilationPhase);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_COMPILER_H_