Use big-boy Types to annotate interface descriptor parameters

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 
 #include <sstream>
 
 #include "src/bootstrapper.h"
 #include "src/cpu-profiler.h"
@@ skipping 484 matching lines @@
   MaybeHandle<Object> result = Execution::Call(
       isolate(), outer, factory->undefined_value(), 2, args, false);
   Handle<JSFunction> inner = Handle<JSFunction>::cast(result.ToHandleChecked());
   // Just to make sure nobody calls this...
   inner->set_code(isolate()->builtins()->builtin(Builtins::kIllegal));
 
   Zone zone;
   // Build a "hybrid" CompilationInfo for a JSFunction/CodeStub pair.
   ParseInfo parse_info(&zone, inner);
   CompilationInfo info(&parse_info);
+  info.SetFunctionType(GetCallInterfaceDescriptor().GetFunctionType());
   info.SetStub(this);
   return info.GenerateCodeStub();
 }
 
 
 template<class StateType>
 void HydrogenCodeStub::TraceTransition(StateType from, StateType to) {
   // Note: Although a no-op transition is semantically OK, it is hinting at a
   // bug somewhere in our state transition machinery.
   DCHECK(from != to);
@@ skipping 524 matching lines @@
   ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
 }
 
 
 InternalArrayConstructorStub::InternalArrayConstructorStub(
     Isolate* isolate) : PlatformCodeStub(isolate) {
   InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
 }
 
 
+Representation RepresentationFromType(Type* type) {

[Benedikt Meurer, 2015/06/22 05:27:28]

So UntaggedFloat64 and UntaggedFloat32 are mapped to Representation::Tagged?
That should be fixed to Representation::Double even if we don't use that
currently.

[Jarin, 2015/06/22 06:51:29]

I would slightly prefer if handled only the cases that we really have and then
do UNREACHABLE for the cases we should not get (such as UntaggedFloat64).

[danno, 2015/06/23 14:39:44]

Done.

[danno, 2015/06/23 14:39:44]

I think I prefer Jaro's suggestion for now, since we don't test these cases and
I'd rather not build in code that isn't actually used.

+  if (type->Is(Type::UntaggedSigned()) || type->Is(Type::UntaggedUnsigned())) {
+    return Representation::Integer32();
+  }
+
+  if (type->Is(Type::TaggedSigned())) {
+    return Representation::Smi();
+  }
+
+  if (type->Is(Type::UntaggedPointer())) {
+    return Representation::External();
+  }
+
+  return Representation::Tagged();
+}
 }  // namespace internal
 }  // namespace v8