Cleanup IFX_BidiChar

core/src/fxcrt/fx_ucddata.cpp

Index: core/src/fxcrt/fx_ucddata.cpp
diff --git a/core/src/fxcrt/fx_ucddata.cpp b/core/src/fxcrt/fx_ucddata.cpp
index 8b35f31e2b23e335b762777bbc63da67335af49d..f93e36a34b8524669fae2c2a3d8c9899484e0e96 100644
--- a/core/src/fxcrt/fx_ucddata.cpp
+++ b/core/src/fxcrt/fx_ucddata.cpp
@@ -6,7 +6,7 @@
 
 #include "../../include/fxcrt/fx_system.h"
 
-extern const FX_DWORD gs_FX_TextLayout_CodeProperties[65536] = {
+extern const FX_DWORD kTextLayout_CodeProperties[1 << (8 * sizeof(FX_WORD))] = {

[Tom Sepez, 2015/08/17 18:55:16]

nit: I find this more confusing than they old way.  Also, since this is a
definition, not a declaration, no need for "extern"

[Lei Zhang, 2015/08/17 22:01:26]

I rewrote it. PTAL.

For the extern, because I didn't include fx_ucd.h, the compiler decided this was
useless code.

     0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93,
     0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe8ae5, 0xfffe9b5c, 0xfffe9ada,
     0xfffe9b1a, 0xfffe9b5b, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93,
@@ -10931,6 +10931,7 @@ extern const FX_DWORD gs_FX_TextLayout_CodeProperties[65536] = {
     0xfffe02a4, 0xfffe02a4, 0xfffe02a4, 0xfffe3013, 0xfffe3013, 0xfffe3013,
     0xfffe3011, 0xfffe3022, 0xfffe1aa4, 0xfffe1aa4,
 };
+
 extern const FX_WCHAR gs_FX_TextLayout_VerticalMirror[64] = {

[Tom Sepez, 2015/08/17 18:55:16]

nit: ditto for no "extern". Probably other places in the file, too.

[Lei Zhang, 2015/08/17 22:01:25]

Done.

     0xFE33, 0xFE32, 0xFE31, 0xFE41, 0xFE42, 0xFE43, 0xFE44, 0xFE3F,
     0xFE40, 0xFE3D, 0xFE3E, 0xFE41, 0xFE42, 0xFE43, 0xFE44, 0xFE3B,