Cleanup IFX_BidiChar

core/src/fpdftext/fpdf_text.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../third_party/base/nonstd_unique_ptr.h"
 #include "../../include/fpdfapi/fpdf_page.h"
 #include "../../include/fpdfapi/fpdf_pageobj.h"
 #include "../../include/fpdftext/fpdf_text.h"
@@ skipping 298 matching lines @@
         return;
     }
     CFX_WideString sBuffer;
     nonstd::unique_ptr<IFX_BidiChar> pBidiChar(IFX_BidiChar::Create());
     CFX_WordArray order;
     FX_BOOL bR2L = FALSE;
     int32_t start = 0, count = 0, i = 0;
     int nR2L = 0, nL2R = 0;
     for (i = 0; i < str.GetLength(); i++) {
         if(pBidiChar->AppendChar(str.GetAt(i))) {
-            int32_t ret = pBidiChar->GetBidiInfo(start, count);
+            IFX_BidiChar::Direction ret =
+                pBidiChar->GetBidiInfo(&start, &count);
             order.Add(start);
             order.Add(count);
             order.Add(ret);
             if(!bR2L) {
-                if(ret == 2) {
+                if (ret == IFX_BidiChar::RIGHT) {
                     nR2L++;
-                } else if (ret == 1) {
+                } else if (ret == IFX_BidiChar::LEFT) {
                     nL2R++;
                 }
             }
         }
     }
     if(pBidiChar->EndChar()) {
-        int32_t ret = pBidiChar->GetBidiInfo(start, count);
+        IFX_BidiChar::Direction ret = pBidiChar->GetBidiInfo(&start, &count);
         order.Add(start);
         order.Add(count);
         order.Add(ret);
         if(!bR2L) {
-            if(ret == 2) {
+            if (ret == IFX_BidiChar::RIGHT) {
                 nR2L++;
-            } else if(ret == 1) {
+            } else if (ret == IFX_BidiChar::LEFT) {
                 nL2R++;
             }
         }
     }
     if(nR2L > 0 && nR2L >= nL2R) {
         bR2L = TRUE;
     }
     if(bR2L) {
         int count = order.GetSize();
         for(int j = count - 1; j > 0; j -= 3) {
@@ skipping 418 matching lines @@
 {
     buffer.EstimateSize(0, 10240);
     CPDF_Page page;
     page.Load(pDoc, pPage);
     CPDF_ParseOptions options;
     options.m_bTextOnly = TRUE;
     options.m_bSeparateForm = FALSE;
     page.ParseContent(&options);
     _PDF_GetTextStream_Unicode(buffer, &page, TRUE, NULL);
 }