Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 1197633002: Serialzier: expand string table as last step before deserializing. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serialzier: expand string table as last step before deserializing. Not doing so could result in this scenario: - We ensure that the string table is large enough. It is. - We compile code stubs, which triggers a GC. - The GC clears string table entries. - This increases the number of deleted entries in the table. - When the deserializer hooks up internalized strings into the table, we ensure that the table is large enough every time. - Due to changed number of deleted entries, the heuristic decides to expand the string table. - Allocation during deserialization causes assertion to fail. BUG=chromium:502085 LOG=N Committed: https://crrev.com/37928334a1129c07c83d17e7a1421f3a3d8e8571 Cr-Commit-Position: refs/heads/master@{#29134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/snapshot/serialize.cc View 3 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
5 years, 6 months ago (2015-06-19 07:13:13 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-19 07:15:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197633002/1
5 years, 6 months ago (2015-06-19 07:18:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 08:07:09 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 08:07:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37928334a1129c07c83d17e7a1421f3a3d8e8571
Cr-Commit-Position: refs/heads/master@{#29134}

Powered by Google App Engine
This is Rietveld 408576698