Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1197593002: X87: Revert of Revert of [strong] Implement strong mode restrictions on property access. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang, Toon Verwaest
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Revert of Revert of [strong] Implement strong mode restrictions on property access. port 41405c0470d5b30ec5d22665ed9430c46b33624f (r29122). fix spelling error in r29122. BUG= Committed: https://crrev.com/48de5f4d6b356d8da9db4afa68814df28e4b575d Cr-Commit-Position: refs/heads/master@{#29133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/ic/x87/ic-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-19 06:11:32 UTC) #2
Toon Verwaest
Thanks for fixing! Lgtm
5 years, 6 months ago (2015-06-19 06:39:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197593002/1
5 years, 6 months ago (2015-06-19 06:39:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 07:20:33 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 07:20:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48de5f4d6b356d8da9db4afa68814df28e4b575d
Cr-Commit-Position: refs/heads/master@{#29133}

Powered by Google App Engine
This is Rietveld 408576698