roll libyuv to 1433 for SIMD implementation of odd width YUV to/from ARGB

roll libyuv to 1433 for SIMD implementation of odd width YUV to/from ARGB

R=brucedawson@chromium.org, wez@chromium.org
BUG=493914
Committed: https://chromium.googlesource.com/chromium/src/+/faf914532fad39e9cfa143487b68d0636a35438d

[fbarchard, 2015-06-19 17:39:34]

fbarchard@chromium.org changed reviewers:
+ fbarchard@chromium.org, wez@chromium.org

[fbarchard, 2015-06-19 17:39:35]

I420ToARGB and ARGBToI420 using SIMD with memcpys on odd width for image
consistency in chromoting with clipping.

[brucedawson, 2015-06-19 21:13:31]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2015-06-19 21:13:31]

Consider adding "summary of changes" link as shown in most other DEPS rolls.
Something like this:

Summary of changes available at:
    https://chromium.googlesource.com/skia/+log/78d79cc..1422ec8

lgtm

[fbarchard, 2015-06-19 22:18:38]

Range of changes
https://chromium.googlesource.com/libyuv/libyuv/+log/b4a0c81..6608c10

[fbarchard, 2015-06-19 22:19:49]

Correction https://chromium.googlesource.com/libyuv/libyuv/+log/2e9f3e5..6608c10

[fbarchard, 2015-06-19 22:21:10]

Local chrome build built ok.  Will need some help on testing

[fbarchard, 2015-06-19 22:30:31]

The CQ bit was checked by fbarchard@chromium.org

[commit-bot: I haz the power, 2015-06-19 22:32:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197553002/1

[fbarchard1, 2015-06-19 22:36:05]

Committed patchset #1 (id:1) manually as
faf914532fad39e9cfa143487b68d0636a35438d (presubmit successful).

[commit-bot: I haz the power, 2015-06-19 22:38:26]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Nico, 2015-06-19 22:47:17]

This breaks the world and had tons of red trybots. Why was this landed manually?

[Nico, 2015-06-19 22:49:01]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1194143002/ by thakis@chromium.org.

The reason for reverting is: Breaks
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/buil....

[scottmg, 2015-06-19 22:49:13]

On 2015/06/19 22:38:26, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
>   android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

Why would you land manually after red trybots?

[chromium-reviews, 2015-06-19 23:45:59]

I did a try, and it was green except android.
I checked bots and they were red on android already.
My try bots for libyuv passed on android.
My local windows build was ok.  So I thought it would be good.

This is my first roll attempt on chrome since the switch to git.  You dont
normally use git cl land?
ps As this will subtly changes image conversions for odd widths I'm
expecting layout tests will need to be recalibrated.
Sorry for the breakage.  Will prepare a new CL but wait on landing it til
Monday.

On Fri, Jun 19, 2015 at 3:49 PM, <scottmg@chromium.org> wrote:

> On 2015/06/19 22:38:26, commit-bot: I haz the power wrote:
>
>> Try jobs failed on following builders:
>>    android_chromium_gn_compile_dbg on tryserver.chromium.linux
>> (JOB_FAILED,
>>
>
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...
> )
>
>>    android_chromium_gn_compile_rel on tryserver.chromium.linux
>> (JOB_FAILED,
>>
>
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...
> )
>
> Why would you land manually after red trybots?
>
> https://codereview.chromium.org/1197553002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2015-06-19 23:53:34]

On 2015/06/19 23:45:59, chromium-reviews wrote:
> I did a try, and it was green except android.
> I checked bots and they were red on android already.
> My try bots for libyuv passed on android.
> My local windows build was ok.  So I thought it would be good.

OK, no problem, but there's a lot of red bots there not just Android, e.g.
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
is clear compile failure in NaCl. I guess just make sure to check all of them if
there's more than one, even though it's tempting to assume all red bots are the
same.

> 
> This is my first roll attempt on chrome since the switch to git.  You dont
> normally use git cl land?
> ps As this will subtly changes image conversions for odd widths I'm
> expecting layout tests will need to be recalibrated.
> Sorry for the breakage.  Will prepare a new CL but wait on landing it til
> Monday.
> 
> On Fri, Jun 19, 2015 at 3:49 PM, <mailto:scottmg@chromium.org> wrote:
> 
> > On 2015/06/19 22:38:26, commit-bot: I haz the power wrote:
> >
> >> Try jobs failed on following builders:
> >>    android_chromium_gn_compile_dbg on tryserver.chromium.linux
> >> (JOB_FAILED,
> >>
> >
> >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...
> > )
> >
> >>    android_chromium_gn_compile_rel on tryserver.chromium.linux
> >> (JOB_FAILED,
> >>
> >
> >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...
> > )
> >
> > Why would you land manually after red trybots?
> >
> > https://codereview.chromium.org/1197553002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.